Skip to content

Commit

Permalink
Adding linter ignores for EDA linters (#249)
Browse files Browse the repository at this point in the history
Issue: AAH-2997
  • Loading branch information
alisonlhart authored Dec 7, 2023
1 parent 165cecc commit 98c7957
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGES/2997.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Ignore certain linter rules for ruff and pylint inside the EDA tox tests.
6 changes: 3 additions & 3 deletions galaxy_importer/ansible_test/container/eda/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ requires =

[testenv:ruff]
deps = ruff
commands = - ruff check --select ALL --ignore INP001 -q {posargs}/extensions/eda/plugins
commands = - ruff check --select ALL --ignore INP001,FA102,UP001,UP010,I001,FA100 -q {posargs}/extensions/eda/plugins


[testenv:darglint]
Expand All @@ -17,8 +17,8 @@ commands = - darglint -s numpy -z full {posargs}/extensions/eda/plugins

[testenv:pylint-event-source]
deps = pylint
commands = - pylint {posargs}/extensions/eda/plugins/event_source/*.py --output-format=parseable -sn --disable R0801
commands = - pylint {posargs}/extensions/eda/plugins/event_source/*.py --output-format=parseable -sn --disable R0801,E0401,C0103,R0913

[testenv:pylint-event-filter]
deps = pylint
commands = - pylint {posargs}/extensions/eda/plugins/event_filter/*.py --output-format=parseable -sn --disable R0801
commands = - pylint {posargs}/extensions/eda/plugins/event_filter/*.py --output-format=parseable -sn --disable R0801,E0401,C0103,R0913
2 changes: 0 additions & 2 deletions tests/integration/test_eda.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@ def test_eda_import(workdir, local_image_config):
assert "Running darglint on /extensions/eda/plugins..." in log
assert "aws_sqs_queue.py:main:33: DAR101" in log
assert "Running pylint on /extensions/eda/plugins/event_source..." in log
assert "aws_sqs_queue.py:29: [E0401" in log
assert "Running pylint on /extensions/eda/plugins/event_filter..." in log
assert "insert_hosts_to_meta.py:31: [E0401" in log
assert "EDA linting complete." in log

assert "Removing temporary files, image and container" in log
Expand Down

0 comments on commit 98c7957

Please sign in to comment.