-
Notifications
You must be signed in to change notification settings - Fork 666
Use antsibull-docutils 1.2.0 to simplify rst-yamllint checker #2745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
83936db
to
93af938
Compare
93af938
to
7ee2c24
Compare
@felixfontein sorry for the delay here. Looks like it needs a rebase now. We've also been asked if we can add xml to the LANGUAGES. Do you know if that's as simple as just adding it to the existing LANGUAGES list in rst-yamllint file? |
7ee2c24
to
d491847
Compare
If you mean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. Gets rid of a bunch of custom stuff and simplifies things so thank you @felixfontein
d491847
to
679d554
Compare
I rebased since #2807 introduced a conflict. |
Backport to stable-2.19: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 51ee33e on top of patchback/backports/stable-2.19/51ee33e26353be7c6be2736c99e1e412745a93b1/pr-2745 Backporting merged PR #2745 into devel
🤖 @patchback |
@oraNod thanks for reviewing this one as well! |
I added code to antsibull-docutils to allow enumeration of code blocks in RST files, based on the code of this repo's rst-yamllint checker. This got released in antsibull-docutils 1.2.0. (I'm using it to provide similar checks for antsibull-nox.)
This PR adjusts the rst-yamllint checker to use antsibull-docutils. This simplifies the checker considerably (no handling of docutils needed anymore!).