Skip to content

[devel] ci: refresh dev dependencies #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

[devel] ci: refresh dev dependencies #2803

merged 1 commit into from
Jul 15, 2025

Conversation

ansible-documentation-bot[bot]
Copy link
Contributor

No description provided.

@ansible-documentation-bot ansible-documentation-bot bot added no_backport This PR should not be backported. devel only. dependency_update PR to update pinned dependencies tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves. labels Jul 13, 2025
@@ -85,7 +85,7 @@ typer==0.16.0
# via -r tests/tag.in
typer-slim==0.16.0
# via -r tests/../hacking/pr_labeler/requirements.txt
types-docutils==0.21.0.20250604
types-docutils==0.21.0.20250710
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixfontein Hi, I'm seeing this in the typing session:

nox > mypy hacking/pr_labeler/pr_labeler hacking/tagger/tag.py noxfile.py docs/bin/find-plugin-refs.py docs/bin/clone-core.py tests/checkers/rst-yamllint.py
tests/checkers/rst-yamllint.py:277: error: Argument 3 to "read" of "Reader" has incompatible type "dict[str, Any]"; expected "Values"  [arg-type]
Found 1 error in 1 file (checked 14 source files)
nox > Command mypy hacking/pr_labeler/pr_labeler hacking/tagger/tag.py noxfile.py docs/bin/find-plugin-refs.py docs/bin/clone-core.py tests/checkers/rst-yamllint.py failed with exit code 1

Looks like publisher.settings is being passed as dict[str, Any] to read here: https://github.com/ansible/ansible-documentation/blob/0408da36a53d0f61c4e86b7b444b2fbb6a42d1ed/tests/checkers/rst-yamllint.py#L277C53-L277C71

Would you mind taking a look? I'm not as familiar with docutils but can try to dig into it later today or tomorrow if you're not around. Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bug in the docutils types (which are maintained independently from docutils itself). I added type: ignore to these places in antsibull-docs and antslbull-docutils.

This is one reason why we should get #2745 merged soon, to no longer have to care about this in this repo.

@oraNod oraNod closed this Jul 15, 2025
@oraNod oraNod reopened this Jul 15, 2025
@oraNod
Copy link
Contributor

oraNod commented Jul 15, 2025

Thanks @felixfontein Looks like merging #2745 did the trick.

@oraNod oraNod merged commit c12d162 into devel Jul 15, 2025
21 of 23 checks passed
@oraNod oraNod deleted the pip-compile/devel/dev branch July 15, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency_update PR to update pinned dependencies no_backport This PR should not be backported. devel only. tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants