Skip to content

feat: replace twitter with x #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025
Merged

feat: replace twitter with x #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/add-community.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ body:
attributes:
label: Bluesky
- type: input
id: twitter
id: x
attributes:
label: Twitter
label: X
- type: input
id: linkedin
attributes:
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export interface Community {
mediaChannel: MediaChannel | null;
logo: string | null;
bluesky: string | null;
twitter: string | null;
x: string | null;
linkedin: string | null;
callForPapers: string | null;
events: Event[];
Expand Down
14 changes: 7 additions & 7 deletions angular-hub/src/app/components/cards/community-card.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,15 @@ import { Community } from '../../../models/community.model';
/>
</a>
}
@if (community().twitterUrl) {
@if (community().xUrl) {
<a
class="rounded-xl bg-[#344255] hover:bg-[#4C5765] p-2"
[attr.href]="community().twitterUrl"
[attr.href]="community().xUrl"
target="_blank"
title="Twitter URL"
title="X URL"
>
<img
ngSrc="/assets/icons/twitter-icon.svg"
ngSrc="/assets/icons/x-twitter-icon.svg"
alt=""
height="30"
width="30"
Expand Down Expand Up @@ -237,15 +237,15 @@ import { Community } from '../../../models/community.model';
/>
</a>
}
@if (community().twitterUrl) {
@if (community().xUrl) {
<a
class="rounded-xl bg-[#344255] p-2"
[attr.href]="community().twitterUrl"
[attr.href]="community().xUrl"
target="_blank"
title="events URL"
>
<img
ngSrc="/assets/icons/twitter-icon.svg"
ngSrc="/assets/icons/x-twitter-icon.svg"
alt=""
height="20"
width="20"
Expand Down
18 changes: 9 additions & 9 deletions angular-hub/src/app/pages/index.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
import { injectLoad, RouteMeta } from '@analogjs/router';
import { NgTemplateOutlet } from '@angular/common';
import { Component, computed, signal, viewChild } from '@angular/core';
import { toSignal } from '@angular/core/rxjs-interop';
import { injectLoad, RouteMeta } from '@analogjs/router';
import { load } from './index.server';
import { CalendarModule } from 'primeng/calendar';
import { FormsModule } from '@angular/forms';
import { Title } from '@angular/platform-browser';
import { isSameDay, isThisISOWeek, isToday, isWithinInterval } from 'date-fns';
import { ButtonModule } from 'primeng/button';
import { CalendarModule } from 'primeng/calendar';
import { DropdownModule } from 'primeng/dropdown';
import { InputSwitchModule } from 'primeng/inputswitch';
import { Title } from '@angular/platform-browser';
import { JsonLdService } from '../services/json-ld.service';
import { Sidebar, SidebarModule } from 'primeng/sidebar';
import { NgTemplateOutlet } from '@angular/common';
import { MessagesModule } from 'primeng/messages';
import { Sidebar, SidebarModule } from 'primeng/sidebar';
import { EventSectionComponent } from '../components/event-section.component';
import { MessageComponent } from '../components/message.component';
import { JsonLdService } from '../services/json-ld.service';
import { load } from './index.server';

export const routeMeta: RouteMeta = {
meta: [
Expand All @@ -31,7 +31,7 @@ export const routeMeta: RouteMeta = {
content: '/api/v1/og-image',
},
{
name: 'twitter:image',
name: 'x:image',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one needs to remain as twitter as its the original metatag. There's no meta tag for x. Same in other places below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, what you said is correct. Seems that I replaced to much of it. I will fix it in a new PR. Thanks for notifying me!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed in #390

content: '/api/v1/og-image',
},
],
Expand Down Expand Up @@ -341,7 +341,7 @@ export default class EventsComponent {
name: 'Gerome Grignon',
url: 'https://www.gerome.dev/',
sameAs: [
'https://twitter.com/GeromeDEV',
'https://x.com/GeromeDEV',
'https://www.linkedin.com/in/gerome-grignon/',
'https://github.com/geromegrignon',
],
Expand Down
8 changes: 4 additions & 4 deletions angular-hub/src/app/pages/watch-party/index.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { afterNextRender, Component, signal } from '@angular/core';
import { RouteMeta } from '@analogjs/router';
import { BannerComponent } from '../../components/banner.component';
import { TableModule } from 'primeng/table';
import { afterNextRender, Component, signal } from '@angular/core';
import { DialogModule } from 'primeng/dialog';
import { InputTextModule } from 'primeng/inputtext';
import { TableModule } from 'primeng/table';
import { BannerComponent } from '../../components/banner.component';

type WatchParty = {
location: string;
Expand All @@ -27,7 +27,7 @@ export const routeMeta: RouteMeta = {
content: '/assets/images/og-image.webp',
},
{
name: 'twitter:image',
name: 'x:image',
content: '/assets/images/og-image.webp',
},
],
Expand Down
2 changes: 1 addition & 1 deletion angular-hub/src/models/community.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export interface Community {
websiteUrl: string | null;
organizersUrl: string | null;
blueskyUrl: string | null;
twitterUrl: string | null;
xUrl: string | null;
linkedinUrl: string | null;
youtubeUrl: string | null;
twitchUrl: string | null;
Expand Down
Loading