feat: replace twitter with x #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for angular-hub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
geromegrignon
approved these changes
Apr 10, 2025
LoganDupont
force-pushed
the
feat/replace_twitter
branch
from
ab3b5e9 to
2bca8bb
Compare
geromegrignon
approved these changes
Apr 13, 2025
|
Thanks @LoganDupont ! |
ajitzero
reviewed
Apr 13, 2025
| @@ -31,7 +31,7 @@ export const routeMeta: RouteMeta = { | |||
| content: '/api/v1/og-image', | |||
| }, | |||
| { | |||
| name: 'twitter:image', | |||
| name: 'x:image', | |||
There was a problem hiding this comment.
I think this one needs to remain as twitter as its the original metatag. There's no meta tag for x. Same in other places below.
There was a problem hiding this comment.
Indeed, what you said is correct. Seems that I replaced to much of it. I will fix it in a new PR. Thanks for notifying me!
There was a problem hiding this comment.
Should be fixed in #390
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Use of twitter keyword in codebase and twitter logo
Issue Number: 386
What is the new behavior?
Use of x keyword in codebase and x logo
Does this PR introduce a breaking change?
There are changes in the openApi yaml where property
twitterUrlchanged toxUrlOther information