Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General updates #165

Merged
merged 10 commits into from
Mar 5, 2025
Merged

General updates #165

merged 10 commits into from
Mar 5, 2025

Conversation

IstvanZsSzekely
Copy link
Collaborator

PR Description

Added/Updated license headers
Updated testbench dependencies
Updated class hierarchy

To be reviewed and merged after #161

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • New test (change that adds new test program and/or testbench)
  • Breaking change (has dependencies in other repositories/testbenches)
  • Documentation (change that adds or modifies documentation)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have ran all testbenches affected by this PR
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Errors on compilation/elaboration/simulation
  • I have set the verbosity level to none for the test program

@IstvanZsSzekely IstvanZsSzekely added the update Update current feature label Jan 27, 2025
@IstvanZsSzekely IstvanZsSzekely self-assigned this Jan 27, 2025
@IstvanZsSzekely IstvanZsSzekely mentioned this pull request Jan 28, 2025
Draft
13 tasks
This was referenced Feb 11, 2025
Open
Open
@IstvanZsSzekely IstvanZsSzekely mentioned this pull request Feb 20, 2025
Draft
13 tasks
@IstvanZsSzekely IstvanZsSzekely mentioned this pull request Mar 4, 2025
Merged
13 tasks
@IstvanZsSzekely
General updates:
a42665f 
- Added/Updated licensce headers
- Updated testbench depndencies
- Updated class hierarchy

Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
@IstvanZsSzekely
SPI VIP update
bd25d30 
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
@IstvanZsSzekely
General updates: Updated VIP clocking and reset calls
4df72a8 
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
@IstvanZsSzekely
general: Change while(1) calls to forever
8cb2dc2 
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
@IstvanZsSzekely
data_offload: Updated dependencies
ecc9706 
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
@IstvanZsSzekely
Copy link
Collaborator Author

Ran a CI build on the branch, fixed issues that are related to these changes.

gastmaier
gastmaier approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@gastmaier gastmaier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, before merging please tidy up the commits
sometimes the format

topic: change

Is followed, and sometimes is not, cluttering the history.
Also spellcheck the commit messages.

For general updates general: <> is fine.

Force pushing the same content with different commit number and messages won't discard the review

@IstvanZsSzekely IstvanZsSzekely merged commit ea85ad3 into main Mar 5, 2025
2 checks passed
@IstvanZsSzekely IstvanZsSzekely deleted the general_updates branch March 5, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastmaier gastmaier gastmaier approved these changes

@LBFFilho LBFFilho Awaiting requested review from LBFFilho

@StancaPop StancaPop Awaiting requested review from StancaPop

Assignees

@IstvanZsSzekely IstvanZsSzekely

Labels
update Update current feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IstvanZsSzekely @gastmaier