Skip to content

Staging/xlnx/handle axi adc legacy #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Staging/xlnx/handle axi adc legacy #3003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d45b53f
microblaze: dts: update axi-adc compatible string to legacy version
nunojsa Oct 23, 2025
3742921
ARM: dts: update axi-adc compatible string to legacy version
nunojsa Oct 23, 2025
2a9e9d8
arm64: dts: update axi-adc compatible string to legacy version
nunojsa Oct 23, 2025
d4901ae
iio: adc: cf_axi_adc_core: update axi-adc compatible string to legacy…
nunojsa Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/intel/socfpga/socfpga_arria10_socdk_adrv9025.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@
};

axi_adrv9025_core_rx: axi-adrv9025-rx-hpc@60000 {
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
reg = <0x00060000 0x8000>;
dmas = <&rx_dma 0>;
dma-names = "rx";
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_de10_nano_cn0501.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
};

axi_adc_ad7768: cf_axi_adc@30000 {
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
reg = <0x00030000 0x10000>;
dmas = <&rx_dma 0>;
dma-names = "rx";
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_de10_nano_cn0579_i2c.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
};

axi_adc_ad7768: cf_axi_adc@30000 {
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
reg = <0x00030000 0x10000>;
dmas = <&rx_dma 0>;
dma-names = "rx";
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sockit_dc2677a.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
};

axi_ltc235x_adc_core: axi-ltc235x@20000 {
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
reg = <0x00020000 0x00010000>;
dmas = <&rx_dma 0>;
dma-names = "rx";
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/xilinx/zynq-coraz7s-cn0579_i2c.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
};

axi_adc_ad7768: cf_axi_adc@44a00000{
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
reg = <0x44a00000 0x10000>;
dmas = <&rx_dma 0>;
dma-names = "rx";
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7625.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@

iio_backend: backend@44a00000{
reg = <0x44a00000 0x10000>;
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
dmas = <&rx_dma 0>;
dma-names = "rx";
clocks = <&ref_clk>;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7768-4-axi-adc.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
};

axi_adc_ad7768: cf_axi_adc@43c00000 {
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
reg = <0x43c00000 0x10000>;
dmas = <&rx_dma 0>;
dma-names = "rx";
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7768-axi-adc.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
};

axi_adc_ad7768: cf_axi_adc@43c00000 {
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
reg = <0x43c00000 0x10000>;
dmas = <&rx_dma 0>;
dma-names = "rx";
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7960.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@

iio_backend: backend@44a00000{
reg = <0x44a00000 0x10000>;
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
dmas = <&rx_dma 0>;
dma-names = "rx";
clocks = <&ref_clk>;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad9467-fmc-250ebz.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
};

cf_ad9467_core_0: cf-ad9467-core-lpc@44a00000 {
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
reg = <0x44A00000 0x10000>;
dmas = <&rx_dma 0>;
dma-names = "rx";
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/xilinx/zynq-zed-adv7511-adaq8092.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
};

axi_adc_adaq8092: adaq8092@44a00000 {
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
reg = <0x44a00000 0x10000>;
dmas = <&rx_dma 0>;
dma-names = "rx";
Expand Down
2 changes: 1 addition & 1 deletion arch/arm64/boot/dts/xilinx/versal-vck190-reva-adrv9025.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
};

axi_adrv9025_core_rx: axi-adrv9025-rx-hpc@a4a00000 {
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
reg = <0xa4a00000 0x8000>;
dmas = <&rx_dma 0>;
dma-names = "rx";
Expand Down
2 changes: 1 addition & 1 deletion arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev10-adrv9025.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@
};

axi_adrv9025_core_rx: axi-adrv9025-rx-hpc@84a00000 {
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
reg = <0x84a00000 0x8000>;
dmas = <&rx_dma 0>;
dma-names = "rx";
Expand Down
2 changes: 1 addition & 1 deletion arch/microblaze/boot/dts/kc705_ad9467_fmc.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

&amba_pl {
axi_ad9467: cf-ad9467-core-lpc@44a00000 {
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
reg = <0x44a00000 0x10000>;
xlnx,s-axi-min-size = <0x0000FFFF>;
dmas = <&rx_dma 0>;
Expand Down
2 changes: 1 addition & 1 deletion arch/microblaze/boot/dts/vcu118_adrv9025.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
};

axi_adrv9025_core_rx: axi-adrv9025-rx-hpc@44a00000 {
compatible = "adi,axi-adc-10.0.a";
compatible = "adi,axi-adc-legacy-10.0.a";
reg = <0x44a00000 0x8000>;
dmas = <&rx_dma 0>;
dma-names = "rx";
Expand Down
2 changes: 1 addition & 1 deletion drivers/iio/adc/cf_axi_adc_core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
stat = axiadc_read(st, ADI_REG_CHAN_STATUS(i));
axiadc_get_pnsel(st, i, &pn_name);

len += sprintf(buf + len, "CH%d : %s : %s %s\n", i, pn_name,

Check failure on line 168 in drivers/iio/adc/cf_axi_adc_core.c

View workflow job for this annotation

GitHub Actions / build_gcc_arm / build 

kernel_smatch: uninitialized symbol 'pn_name'.
(stat & ADI_PN_OOS) ? "Out of Sync :" : "In Sync :",
(stat & (ADI_PN_ERR | ADI_PN_OOS)) ? "PN Error" : "OK");
axiadc_write(st, ADI_REG_CHAN_STATUS(i), ~0);
Expand Down Expand Up @@ -242,17 +242,17 @@
if (!(reg & DEBUGFS_DRA_PCORE_REG_MAGIC)) {
struct axiadc_converter *conv = to_converter(st->dev_spi);
if (IS_ERR(conv))
ret = PTR_ERR(conv);

Check warning on line 245 in drivers/iio/adc/cf_axi_adc_core.c

View workflow job for this annotation

GitHub Actions / build_llvm_x86_64 / build 

clang_analyzer: Value stored to 'ret' is never read [deadcode.DeadStores]
245 | ret = PTR_ERR(conv);
| ^ ~~~~~~~~~~~~~
else if (!conv->reg_access)
ret = -ENODEV;

Check warning on line 247 in drivers/iio/adc/cf_axi_adc_core.c

View workflow job for this annotation

GitHub Actions / build_llvm_x86_64 / build 

clang_analyzer: Value stored to 'ret' is never read [deadcode.DeadStores]
247 | ret = -ENODEV;
| ^ ~~~~~~~
else
ret = conv->reg_access(indio_dev, reg, writeval, readval);

Check warning on line 249 in drivers/iio/adc/cf_axi_adc_core.c

View workflow job for this annotation

GitHub Actions / build_llvm_x86_64 / build 

clang_analyzer: Value stored to 'ret' is never read [deadcode.DeadStores]
249 | ret = conv->reg_access(indio_dev, reg, writeval, readval);
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
} else {
if (readval == NULL)
axiadc_write(st, reg & 0xFFFF, writeval);
else
*readval = axiadc_read(st, reg & 0xFFFF);
ret = 0;

Check warning on line 255 in drivers/iio/adc/cf_axi_adc_core.c

View workflow job for this annotation

GitHub Actions / build_llvm_x86_64 / build 

clang_analyzer: Value stored to 'ret' is never read [deadcode.DeadStores]
255 | ret = 0;
| ^ ~
}
mutex_unlock(&conv->lock);

Expand Down Expand Up @@ -939,7 +939,7 @@
{ .compatible = "adi,axi-adrv9009-rx-1.0", .data = &axi_adc_10_0_a_info },
{ .compatible = "adi,axi-ad9208-1.0", .data = &axi_adc_10_0_a_info },
{ .compatible = "adi,axi-ad9081-rx-1.0", .data = &axi_adc_10_0_a_info },
{ .compatible = "adi,axi-adc-10.0.a", .data = &axi_adc_10_0_a_info },
{ .compatible = "adi,axi-adc-legacy-10.0.a", .data = &axi_adc_10_0_a_info },
{ .compatible = "adi,axi-adrv9002-rx-1.0", .data = &axi_adc_10_1_b_info},
{ .compatible = "adi,axi-adrv9003-rx-1.0", .data = &axi_adc_10_1_b_info},
{ .compatible = "adi,axi-adrv9004-rx-1.0", .data = &axi_adc_10_1_b_info},
Expand Down Expand Up @@ -1229,7 +1229,7 @@
static struct platform_driver axiadc_driver = {
.driver = {
.name = KBUILD_MODNAME,
.owner = THIS_MODULE,

Check warning on line 1232 in drivers/iio/adc/cf_axi_adc_core.c

View workflow job for this annotation

GitHub Actions / checks / checks 

coccicheck: 3-8  No need to set .owner here. The core will do it.
.of_match_table = axiadc_of_match,
},
.probe = axiadc_probe,
Expand Down
Loading