feat: Adjust account configuration (#403)

* feat: adjust AccountConfiguration model * feat: adjust unit test for account configurations * fix: removed not used enum
alpacahq · Jan 25, 2024 · 03fb917 · 03fb917
1 parent 9853fcb
commit 03fb917
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/alpaca/trading/enums.py b/alpaca/trading/enums.py
@@ -346,7 +346,7 @@ class TradeConfirmationEmail(str, Enum):
     """
     Used for controlling when an Account will receive a trade confirmation email.
 
-    please see https://alpaca.markets/docs/api-references/broker-api/trading/trading-configurations/#attributes
+    please see https://docs.alpaca.markets/reference/getaccountconfig
     for more info.
     """
 

diff --git a/alpaca/trading/models.py b/alpaca/trading/models.py
@@ -544,6 +544,7 @@ class AccountConfiguration(BaseModel):
         suspend_trade (bool): If true Account becomes unable to submit new orders
         trade_confirm_email (TradeConfirmationEmail): Controls whether Trade confirmation emails are sent.
         ptp_no_exception_entry (bool): If set to true then Alpaca will accept orders for PTP symbols with no exception. Default is false.
+        max_option_trading_level (Optional[str]): The desired maximum option trading level. 0=disabled, 1=Covered Call/Cash-Secured Put, 2=Long Call/Put.
     """
 
     dtbp_check: DTBPCheck
@@ -554,6 +555,7 @@ class AccountConfiguration(BaseModel):
     suspend_trade: bool
     trade_confirm_email: TradeConfirmationEmail
     ptp_no_exception_entry: bool
+    max_option_trading_level: Optional[str] = None
 
 
 class CorporateActionAnnouncement(ModelWithID):

diff --git a/tests/trading/trading_client/test_account_routes.py b/tests/trading/trading_client/test_account_routes.py
@@ -64,14 +64,16 @@ def test_get_account_configurations(reqmock: Mocker, trading_client: TradingClie
           "max_margin_multiplier": "4",
           "pdt_check": "entry",
           "trade_confirm_email": "all",
-          "ptp_no_exception_entry": false
+          "ptp_no_exception_entry": false,
+          "max_option_trading_level": "1"
         }
       """,
     )
 
     account_configurations = trading_client.get_account_configurations()
     assert reqmock.called_once
     assert isinstance(account_configurations, AccountConfiguration)
+    assert account_configurations.max_option_trading_level == "1"
 
 
 def test_set_account_configurations(reqmock: Mocker, trading_client: TradingClient):