Skip to content

Commit

Permalink
feat: Add new fields into trade account (#402)
Browse files Browse the repository at this point in the history
* feat: add option_approved_level/option_trading_level into trade account

* feat: adjust unit test for account
  • Loading branch information
hiohiohio authored Jan 25, 2024
1 parent 8e28e7f commit 9853fcb
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
6 changes: 6 additions & 0 deletions alpaca/trading/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,10 @@ class TradeAccount(ModelWithID):
sma (Optional[str]): Value of Special Memorandum Account (will be used at a later date to provide additional buying_power)
daytrade_count (Optional[int]): The current number of daytrades that have been made in the last 5 trading days
(inclusive of today)
option_approved_level (Optional[int]): The option trading level that was approved for this account.
0=disabled, 1=Covered Call/Cash-Secured Put, 2=Long Call/Put.
option_trading_level (Optional[int]): The effective option trading level of the account. This is the minimum between account option_approved_level and account configurations max_option_trading_level.
0=disabled, 1=Covered Call/Cash-Secured Put, 2=Long
"""

account_number: str
Expand Down Expand Up @@ -523,6 +527,8 @@ class TradeAccount(ModelWithID):
last_maintenance_margin: Optional[str] = None
sma: Optional[str] = None
daytrade_count: Optional[int] = None
option_approved_level: Optional[int] = None
option_trading_level: Optional[int] = None


class AccountConfiguration(BaseModel):
Expand Down
6 changes: 5 additions & 1 deletion tests/trading/trading_client/test_account_routes.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ def test_get_account(reqmock: Mocker, trading_client: TradingClient):
"status": "ACTIVE",
"trade_suspended_by_user": false,
"trading_blocked": false,
"transfers_blocked": false
"transfers_blocked": false,
"option_approved_level": "1",
"option_trading_level": "1"
}
""",
)
Expand All @@ -46,6 +48,8 @@ def test_get_account(reqmock: Mocker, trading_client: TradingClient):

assert reqmock.called_once
assert isinstance(account, TradeAccount)
assert account.option_approved_level == 1
assert account.option_trading_level == 1


def test_get_account_configurations(reqmock: Mocker, trading_client: TradingClient):
Expand Down

0 comments on commit 9853fcb

Please sign in to comment.