Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last version of the code #36

Merged
merged 24 commits into from
Apr 1, 2025
Merged

Last version of the code #36

merged 24 commits into from
Apr 1, 2025

Conversation

laurentbouquin
Copy link
Collaborator

Please describe the changes this PR makes and why it should be merged

Status and versioning classification

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

Biohazardyee and others added 23 commits March 26, 2025 09:50
- Add settings menu (not interracting with the schematics)
- Add dedicated javascript and css files for the settings.
- Correct folder Input too big on launch.
- Chnage some wires id that came from the `drawBasicConnection` function
- Change clock background gradient to comply with the mock-up
Fix the position of the clock when not enough elements are displayed to have the page scrollable.
started implementing the animations
- Correct flip flop to output wire ids
- Remove useless `console.log` lines
- Add functions for working animations
The client said that he wanted to use our formats to create examples himself without needing extra code, so this file could help him do that.
I had pushed the wrong version...
So here is the right reason
made the code not case-sensitive and made the connection adding, more permissive.
added a stop.
Copy link
Collaborator

@JasonGROSSO JasonGROSSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Untitled

Copy link
Collaborator

@GuillaumeDespaux GuillaumeDespaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@GuillaumeDespaux GuillaumeDespaux merged commit 1008dde into main Apr 1, 2025
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants