Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project manager #57

Closed
wants to merge 8 commits into from
Closed

Project manager #57

wants to merge 8 commits into from

Conversation

habicll
Copy link
Collaborator

@habicll habicll commented Feb 14, 2025

Pull Request

Description

Please include a summary of the change or which issue is fixed. If necessary list any dependencies that are required for this change.

just week 6 adding

Prerequisites

Type of change

  • Issue fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Has this been tested / reviewed?

  • Yes
  • No

Checklist

  • My code follows the style guidelines of this project
  • I have asked for a code review
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Remarks

Please provide any additional information that you think is important or relevant.

@habicll habicll added the documentation Improvements or additions to documentation label Feb 14, 2025
@habicll habicll self-assigned this Feb 14, 2025
Copy link
Collaborator

@JasonGROSSO JasonGROSSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unecessary files such as google test and code folders

Copy link
Collaborator

@MistzSoftware MistzSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major issues, have to be fixed ASAP, and be more careful next time, to not push confidential data accidentaly

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the folder build shouldn't be pushed on github

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the folder googletest shouldn't be pushed on github

@habicll habicll closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants