-
Notifications
You must be signed in to change notification settings - Fork 19
Switch to using the local IPFS Kubo daemon for IPFS files #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -133,6 +135,32 @@ async def download_file(url: str, local_path: Path) -> None: | |||
tmp_path.unlink(missing_ok=True) | |||
|
|||
|
|||
async def download_file_from_ipfs_or_connector(ref: str, cache_path: Path, filetype: str) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async def download_file_from_ipfs_or_connector(ref: str, cache_path: Path, filetype: str) -> None: | |
async def download_file_from_ipfs_or_connector(item_hash: ItemHash, cache_path: Path, filetype: str) -> None: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
==========================================
+ Coverage 63.33% 63.41% +0.07%
==========================================
Files 77 77
Lines 6854 6877 +23
Branches 576 578 +2
==========================================
+ Hits 4341 4361 +20
- Misses 2325 2326 +1
- Partials 188 190 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IPFS Kubo is now present on all CRNs but unused. Downloading files from this service would be more reliable than using third party and provide content integrity checks. This bypasses the vm-connector when fetching resources from IPFS.
Kubo service could also use unlimited memory.
@olethanh I moved the resource limits into this branch. |
IPFS Kubo is now present on all CRNs but unused.
Downloading files from this service would be more reliable than using
third party and provide content integrity checks.
This bypasses the vm-connector when fetching resources from IPFS.
Related Jira tickets : ALEPH-36
Self proofreading checklist
packaging/Makefile
Changes
IPFS_SERVER
inaleph-vm
.How to test
Stop the services, purge all application data, then restart the services.
Then check that the index page of the CRN.