-
Notifications
You must be signed in to change notification settings - Fork 19
Fix: IPFS Kubo could use unlimited resources #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 63.26% 63.26%
=======================================
Files 77 77
Lines 6855 6855
Branches 576 576
=======================================
Hits 4337 4337
Misses 2329 2329
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8866394
to
d9cd8ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
According to the Kubo doc we should also set GOMEMLIMIT env var to avoid having it OOM killed
|
forgot link to Kubo doc here : https://github.com/ipfs/kubo/blob/master/docs/config.md#swarmresourcemgrmaxmemory Will add the modification |
9bb47ce
to
1e8a93d
Compare
CI failed due to:
|
In observations on multiple CRNs and CCNs, it seems to use around 700-900 MB. Limiting the resources to 2GB and hard to 4GB seems therefore sensible.
1e8a93d
to
b08df08
Compare
failing because of
|
This approach does not work with recent versions of Kubo, see https://github.com/aleph-im/aleph-vm/pull/779/files where we use systemd |
Moved into #779 |
In observations on multiple CRNs and CCNs,
it seems to use around 700-900 MB.
Limiting the resources to 2GB and hard to 4GB
seems therefore sensible.