Migrate to RxJava2 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
felipecsl
approved these changes
Jul 5, 2017
| public <T> Observable.Transformer<? super T, T> transform(Observer<? super T> observer, | ||
| String observableTag) { | ||
| public <T> ObservableTransformer<? super T, T> transform(Observer<? super T> observer, | ||
| String observableTag) { |
There was a problem hiding this comment.
nit: you should disable "align when multiline"
| * is subscribed to one {@link Observable}. | ||
| */ | ||
| public <T> void resubscribe(TaggedObserver<? super T> observer) { | ||
| resubscribe(observer, Utils.getObserverTag(observer)); |
BenSchwab
pushed a commit
that referenced
this pull request
Jan 2, 2018
* Add observer tag * annotation processor * fix lifecycle test * fix tests * Add observer tag * annotation processor * fix lifecycle test * fix tests * Clean up tests and bump version to 1.0.0-SNAPSHOT * address comments * Create Processor Project, DRY gradle dependencies (#37) * Move rxgroups-processor to separate project, DRY multi-module dependencies * renamen package to processor, fix spacing * rxgroups-android tests need to depend on processor * Switch line limit back to 100, update gradle to 3.5 * get checkstyle to work with gradle 3.5 * Make ObservableGroup#resubscribe visible to generated code, artificat for rx-processor (#38) * Have rxgroups-processor upload build artifact Use variable for repo urls * Make ObseravbleGroup#resubscribe public for generated code. Remove deprecated use of Observable#create * Use getter/setter with JavaDoc * fix checkstyle * Add back javadoc quiet mode * Use subclass to control visability * Make mulitiple observer support more clear (#39) * Make mulitiple observer support more clear * fix checkystyle * Consistently use the term observableTag for user facing code, and observerTag where necessary internally * Add test for multiple observers, cancelAndRemoveAllWithTag * Update all tests to reflect the use of observerTag instead of null in 1:1 case * remove extra space * Fix javadocs * Remove cancelling by observableTag * remove unused observableTag code * fix another typo * Add tagged observer to allow for custom tag (#40) * Add tagged observer to allow for using a non-auto generated observer tag in exceptional circumstances * Support auto resubcription with tagged observer * add tests * Add AutoTag, NonResubscribableTag, safeInitialize (#41) * Add AutoTag, safeIntialization, and NonResubscribingTag * revert gradle change * Fix some comments * Change to NonResubscribable * fix test * propogate cancel and remove all change to lifecyclemanager * remove duplicated method * fix test name * Cache missing constructors, add super class initialization support change some access fix some more * Make GroupLifecycleManager properly shadow methods in ObservableGroup * disable check style for mock generated code * reduce chance of concurrent modification exception * Add supression comment filter * Add filecontentsholder to have checkstyle actually read turn off comments * remove duplicated remove code * Add AnnotationProcessor code gen tests * use config build tools version * fix no checkstyle check * add missing new lines * Change version to 1.0.0-alpha1 * Prevent null tag collisions by resorting to NonResubscribingTag, if getTag returns null * add test for custom tagging * eliminate double map lookup * Migrate to RxJava2 (#42) * Migrate to RxJava2 for Observables cleanup * update tests and sample for rxjava2 * update travis * Fix test checkstyle * fix line alignment * Fix some documentation * Fix continuation idents, use 2 spaces in ObservableGroup (#43) * bump version (#44)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #34
This is a stab at migrating to RxJava2:
Code changes: b8e5313
Test changes: ab21d32
Most of the code changes are simple mappings from: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0.
Two things to note:
SubscriptionProxyand wrap it with a freshDisposableObserverevery time we subscribe. With the changes to disposables, it is now safe to calldisposeon the observer used on the transformed observable directly, instead of going throughSourceSubscription. Of course, this will still leave theSourceSubscriptionsubscribed, untilcancelis called.The test changes may seem like a lot, but most of the changes are caused by:
ObservableGroup#addtakes an emitter -- this means the easiest way to test was using theGroupSubscriptionTransformer