Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJava2? #34

Open
sgrekov opened this issue Feb 14, 2017 · 11 comments
Open

RxJava2? #34

sgrekov opened this issue Feb 14, 2017 · 11 comments

Comments

@sgrekov
Copy link

sgrekov commented Feb 14, 2017

Hi!
Do you have any plans for migrating or any guides for using it with RxJava2?
Since RxJava2 released 3 months ago, I think it soon will be a major blocker for using this library.

@felipecsl
Copy link
Contributor

Now that Retrofit 2.2.0 is out with first party support for RxJava 2, I think we can finally upgrade.
So yes, this should happen soon!

@sgrekov
Copy link
Author

sgrekov commented Feb 23, 2017

Cool! Thanks!

@rahulrj
Copy link

rahulrj commented Jun 26, 2017

Hi @felipecsl i am working on migrating this library to RxJava2. Do you want to give any suggestions/ pointers for it?

@elihart
Copy link
Contributor

elihart commented Jun 27, 2017

@BenSchwab started work on the RxJava2 migration I believe.

@elihart
Copy link
Contributor

elihart commented Jun 27, 2017

There is quite a lot of new work in the 1.0 branch and the migration will probably happen there. not sure if it is worth making changes to master at this point.

@BenSchwab
Copy link
Contributor

Yes, working on a RxJava2 migration now. I would prefer to keep the changes in the 1.0 branch. If you have started to think about the migration, would appreciate your feedback when I put up the PR @rahulrj

@rahulrj
Copy link

rahulrj commented Jul 9, 2017

@BenSchwab how is the code in master branch different from the 1.0 branch? Is 1.0 the active development branch and will it eventually get merged to master?

@BenSchwab
Copy link
Contributor

Yep, 1.0 is the active development branch for the time being, with experimental features like annotation process based tagging - and now RxJava2. We are testing internally (and the branch may experience API churn) before elevating to a general 1.0 release.

@rahulrj
Copy link

rahulrj commented Jul 13, 2017

Okay @BenSchwab . I was also working parallely on the RxJava2 migration. But i converted the code of the master branch. Because the name 1.0 looked like that might be some old 1.0 release.

@meierjan
Copy link

meierjan commented Dec 14, 2017

any updates here? :)

[edit]

and can you maybe publish alpha2 so that one can test as well?

@JEuler
Copy link
Contributor

JEuler commented May 1, 2018

Hi! Any updates for rxjava 2.0 support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants