Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify that user-specified ids are only required on management plane requests #1250

Merged
merged 2 commits into from
Dec 12, 2023
Merged

clarify that user-specified ids are only required on management plane requests #1250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c2c5a9
clarify that user-specified ids are only required on management plane…
andrei-scripniciuc Oct 20, 2023
e3f5719
Merge branch 'master' into clarify-resource-id-aip-133
andrei-scripniciuc Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion aip/general/0133.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ message CreateBookRequest {
- The field **should** be [annotated as required][aip-203].
- The field **must** identify the [resource type][aip-123] of the resource
being created.
- A `{resource}_id` field **must** be included.
- A `{resource}_id` field **must** be included for management plane resources,
and **should** be included for data plane resources.
- The resource field **must** be included and **must** map to the POST body.
- The request message **must not** contain any other required fields and
**should not** contain other optional fields except those described in this
Expand Down Expand Up @@ -217,6 +218,7 @@ name and use it in references from other resources.

## Changelog

- **2023-10-20**: Clarify that {resource}_id is only required for management plane resources.
- **2023-08-24**: Adding consistency requirement.
- **2023-05-11**: Changing guidance around resource_id to a must.
- **2022-11-04**: Referencing aggregated error guidance in AIP-193, similar to
Expand Down