Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify that user-specified ids are only required on management plane requests #1250

Merged
merged 2 commits into from
Dec 12, 2023
Merged

clarify that user-specified ids are only required on management plane requests #1250

merged 2 commits into from
Dec 12, 2023

Conversation

andrei-scripniciuc
Copy link
Contributor

No description provided.

@andrei-scripniciuc andrei-scripniciuc requested a review from a team as a code owner October 20, 2023 19:08
itsStrobe
itsStrobe approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@itsStrobe itsStrobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrei-scripniciuc andrei-scripniciuc merged commit dd07c58 into aip-dev:master Dec 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsStrobe itsStrobe itsStrobe approved these changes

@noahdietz noahdietz noahdietz approved these changes

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607 bgrant0607 is a code owner automatically assigned from aip-dev/google

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrei-scripniciuc @noahdietz @itsStrobe