-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Added test cases for feature based clustering #2690
base: main
Are you sure you want to change the base?
[ENH] Added test cases for feature based clustering #2690
Conversation
Thank you for contributing to
|
…tering' into test_case_for_feature_based_clustering
…tering' into test_case_for_feature_based_clustering # Conflicts: # aeon/clustering/feature_based/tests/test_catch22.py # aeon/clustering/feature_based/tests/test_summary.py # aeon/clustering/feature_based/tests/test_tsfresh.py
Hi, this does not seem to add much that the general testing does not test. It would be better to add any expected results to the |
…tering' into test_case_for_feature_based_clustering # Conflicts: # aeon/clustering/feature_based/tests/test_tsfresh.py
…tering' into test_case_for_feature_based_clustering
…tering' into test_case_for_feature_based_clustering
Hi, I added extra test cases and made sure they cover 80%+ of the code (except for cases where an estimator is passed), here’s what the tests check: 1.Whether the ARI scores are correct Let me know if this is fine or if I should add more.I will use this as a reference for the other 2 PR if it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Added test cases for feature based clustering
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access