Support minibuffer-history-variable being disabled #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emacs 28 minibuffer history can be disabled with a value of t. * ivy.el (ivy--update-history, ivy-reverse-i-search-kill): Leave history variable alone if it is t. (ivy--label-and-delete-dups): Avoid unnecessarily creating a hash table for zero entries. (ivy--reverse-i-search-symbol): Rename... (ivy--reverse-i-search-history): ...to this more accurate name. All uses changed. (ivy-history-contents): Return nil if history variable is t. Ensure ivy--reverse-i-search-history is set to a valid value. Fixes #2923.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emacs 28 minibuffer history can be disabled with a value of t.
ivy.el(ivy--update-history,ivy-reverse-i-search-kill): Leave history variable alone if it ist.(
ivy--label-and-delete-dups): Avoid unnecessarily creating a hash table for zero entries.(
ivy--reverse-i-search-symbol): Rename...(
ivy--reverse-i-search-history): ...to this more accurate name.All uses changed.
(
ivy-history-contents): Returnnilif history variable ist.Ensure
ivy--reverse-i-search-historyis set to a valid value.Fixes #2923.
Cc: @minad, @NightMachinary