Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support history=t in Ivy #2923

Closed
minad opened this issue Oct 9, 2021 · 2 comments · Fixed by #2965
Closed

Support history=t in Ivy #2923

minad opened this issue Oct 9, 2021 · 2 comments · Fixed by #2965
Labels
compat Issues relating to backward/forward compatibility

Comments

@minad
Copy link

minad commented Oct 9, 2021

History=t disables the history. This value is allowed by Emacs 28 for completing-read. See minad/consult#441 for a typical stack trace.
@minad minad changed the title Support history=t Support history=t in Ivy Oct 9, 2021
This was referenced Oct 9, 2021
Closed
Closed
@NightMachinery
Copy link

Thanks for creating the issue!

@basil-conto basil-conto added the compat Issues relating to backward/forward compatibility label Apr 6, 2022
@basil-conto basil-conto mentioned this issue Apr 6, 2022
Merged
@basil-conto
Copy link
Collaborator

Thanks for reporting this. Does #2965 address the problem, or is there more to it than that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compat Issues relating to backward/forward compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support minibuffer-history-variable being disabled abo-abo/swiper
3 participants
@minad @basil-conto @NightMachinery