-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rp2040: Add spi slave example #391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68b7839
to
13457f1
Compare
13457f1
to
dca8aa6
Compare
Grazfather
commented
Feb 17, 2025
Grazfather
commented
Feb 17, 2025
Grazfather
commented
Feb 17, 2025
Grazfather
commented
Feb 17, 2025
Grazfather
commented
Feb 17, 2025
Grazfather
commented
Feb 17, 2025
Grazfather
commented
Feb 17, 2025
mattnite
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a SPI slave example.
This one behaves like the example linked from the spi master example, but doesn't work with the spi master example.
That example switches between 12 and 8 bit mode, which is cool, but in practice is hard to synchronize.
I'd propose dropping that part from the example so that spi master and spi slave can actually behave with each other.
Tested by removing the 12-bit part of the spi master code, as well as against the spi master pico-examples code.
TODO: