Skip to content

Add Windows 11 arm support to ci #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Windows 11 arm support to ci #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3627e44
Add Windows 11 arm support to ci
mcbarton Apr 17, 2025
86ba733
Explain why rust needs installing Windows 11 arm ci job, but not Wind…
mcbarton May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/actions/install-deps/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@ runs:
shell: bash
- name: Install ccache, ninja (Windows)
run: choco install ccache ninja
if: runner.os == 'Windows'
if: startsWith(matrix.os, 'windows')
shell: bash
# Windows arm runners don't come with rust by default (see https://github.com/actions/partner-runner-images/blob/main/images/arm-windows-11-image.md)
# but the x86 ones do (see https://github.com/actions/runner-images/blob/main/images/windows/Windows2025-Readme.md)
- name: Install cargo (Windows-arm)
run: choco install rust
if: matrix.os == 'windows-11-arm'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed on arm-windows, only? Maybe worth a comment?

Copy link
Contributor Author

@mcbarton mcbarton May 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly its because the Windows arm runners don't come with rust by default (see https://github.com/actions/partner-runner-images/blob/main/images/arm-windows-11-image.md) , but the x86 ones do (see https://github.com/actions/runner-images/blob/main/images/windows/Windows2025-Readme.md ). Would this comment in the action.yml file suffice?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes a comment right here seems like a good idea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

shell: bash
- name: Install ccache, ninja (Linux)
run: sudo apt-get install -y ccache ninja-build
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ jobs:
- artifact: x86_64-windows
os: windows-2022

- artifact: arm64-windows
os: windows-11-arm

env: ${{ matrix.env || fromJSON('{}') }}
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -102,7 +105,7 @@ jobs:
#
# As of 2024-07-22 this sha is the "v1.13.0" tag.
- uses: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756
if: runner.os == 'Windows'
if: startsWith(matrix.os, 'windows')
- name: Build and test (Windows)
run: |
# Delete a troublesome binary as recommended here
Expand All @@ -117,7 +120,7 @@ jobs:
mkdir build
cp -r C:/wasi-sdk/dist build
shell: bash
if: runner.os == 'Windows'
if: startsWith(matrix.os, 'windows')

# Upload the `dist` folder from the build as the artifacts for this
# runner.
Expand Down