Add Windows 11 arm support to ci #524
Conversation
|
Will investigate the failures here https://github.com/WebAssembly/wasi-sdk/actions/runs/14522826687/job/40747554325?pr=524#step:12:90 and here https://github.com/WebAssembly/wasi-sdk/actions/runs/14522826687/job/40747554325?pr=524#step:12:92 tomorrow if I can |
mcbarton
force-pushed
the
Add-Windows-11-arm-ci
branch
2 times, most recently
from
da8dbbf to
722738a
Compare
|
@sbc100 can you manually rerun the failing workflow jobs? The 2 failing jobs are due an issue with the runners internet connection when the job started (see error in output messages in workflow runs). Rerunning the failed jobs they should pass, and then this PR is ready for review. |
|
I hit retry |
|
@alexcrichton @sbc100 this PR is ready for review. |
| shell: bash | ||
| - name: Install cargo (Windows-arm) | ||
| run: choco install rust | ||
| if: matrix.os == 'windows-11-arm' |
There was a problem hiding this comment.
Why is this needed on arm-windows, only? Maybe worth a comment?
There was a problem hiding this comment.
If I remember correctly its because the Windows arm runners don't come with rust by default (see https://github.com/actions/partner-runner-images/blob/main/images/arm-windows-11-image.md) , but the x86 ones do (see https://github.com/actions/runner-images/blob/main/images/windows/Windows2025-Readme.md ). Would this comment in the action.yml file suffice?
There was a problem hiding this comment.
Yes a comment right here seems like a good idea.
Try installing cargo Windows arm Update action.yml
mcbarton
force-pushed
the
Add-Windows-11-arm-ci
branch
from
35481b1 to
86ba733
Compare
|
@sbc100 There appears to be an internet connection issue with the Github runners in the ci at the moment. If you manually rerun the workflow later it should pass. |
This PR should hopefully fix #522 . According to https://github.blog/changelog/2025-04-14-windows-arm64-hosted-runners-now-available-in-public-preview/ Windows arm Github runners are now available for free for public repositories. Therefore I have added them to wasi-sdks ci.