Skip to content

Support Multi-SRP in SeedlessOnboardingController #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 32 commits into
base: feat/seedless-onboarding-controller
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
11d6552
feat: added 'encryptionKey' and 'encryptionSalt' to state
lwin-kyaw Apr 22, 2025
5a2953c
feat: add new private method, 'verifyPassword` to verify password val…
lwin-kyaw Apr 22, 2025
3aa52ba
feat: updated vault encryption scheme
lwin-kyaw Apr 22, 2025
5347ab5
feat: add new method 'addNewSeedPhraseBackup' for multi-srp
lwin-kyaw Apr 22, 2025
3301236
fix: fixed vaultEncKey and password check
lwin-kyaw Apr 22, 2025
534f04c
test: updated tests for multi-srp and new vault encryption scheme
lwin-kyaw Apr 22, 2025
57636e6
lint: removed unused imports
lwin-kyaw Apr 22, 2025
b15d1d9
feat: locked controller and clear secrets on keyring lock state
lwin-kyaw Apr 22, 2025
6cae65b
fix: removed password cache value from Controller
lwin-kyaw Apr 22, 2025
f8dd9fb
test: fixed and updated tests
lwin-kyaw Apr 22, 2025
4e3447e
Merge remote-tracking branch 'origin/feat/seedless-onboarding-control…
lwin-kyaw Apr 24, 2025
9198631
feat: sync SeedlessOnboardingController lock with Keyring
lwin-kyaw Apr 24, 2025
9716513
feat: allow multiple backupState in updateBackupMetadataState method
lwin-kyaw Apr 25, 2025
ad56538
feat: change order of seedPhrases in fetchAllSeedPhrase method
lwin-kyaw Apr 25, 2025
f2b5d96
fix: use Keyring Encryptor as vault encryptor
lwin-kyaw Apr 29, 2025
9b2cb7b
chore: added controller tgz to git
lwin-kyaw Apr 29, 2025
b22516f
fix: encryptor type
ieow Apr 29, 2025
31d7796
fix: remove un-needed typing
ieow Apr 29, 2025
4dcc584
Merge pull request #7 from Web3Auth/fix/encryptor-type
lwin-kyaw Apr 29, 2025
ea742ec
chore: updated tgz
lwin-kyaw Apr 29, 2025
885b798
fix: remove web encryptor from controller
ieow Apr 30, 2025
816abb7
feat: update package.tgz
ieow Apr 30, 2025
5de4c1d
fix: make setUnlocked public
ieow Apr 30, 2025
51da766
feat: update package.tgz
ieow Apr 30, 2025
37f7a80
fix: cannot write private member
ieow Apr 30, 2025
e26e29b
feat: update package.tgz
ieow Apr 30, 2025
bc23413
Merge remote-tracking branch 'origin/fix/encryptor-type' into fix/enc…
lwin-kyaw May 6, 2025
b5931c1
fix: fixed tests
lwin-kyaw May 6, 2025
3065919
Merge pull request #8 from Web3Auth/fix/encryptor-type
lwin-kyaw May 6, 2025
e160282
Merge remote-tracking branch 'origin/feat/seedless-onboarding-control…
lwin-kyaw May 6, 2025
b7201c3
Merge remote-tracking branch 'origin/feat/seedless-multi-srp' into fe…
lwin-kyaw May 6, 2025
c1619fc
fix: removed 'assertIsUnlocked' check in 'setLock' method
lwin-kyaw May 6, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/seedless-onboarding-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,14 @@
"dependencies": {
"@metamask/auth-network-utils": "^0.1.0",
"@metamask/base-controller": "^8.0.0",
"@metamask/browser-passworder": "^4.3.0",
"@metamask/toprf-secure-backup": "^0.1.0",
"@metamask/utils": "^11.2.0",
"async-mutex": "^0.5.0"
},
"devDependencies": {
"@metamask/auto-changelog": "^3.4.4",
"@metamask/browser-passworder": "^4.3.0",
"@metamask/keyring-controller": "^21.0.3",
"@noble/ciphers": "^0.5.2",
"@noble/curves": "^1.2.0",
"@noble/hashes": "^1.4.0",
Expand All @@ -70,6 +71,9 @@
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "~5.2.2"
},
"peerDependencies": {
"@metamask/keyring-controller": "^21.0.0"
},
"engines": {
"node": "^18.18 || >=20"
},
Expand Down
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class SeedPhraseMetadata implements ISeedPhraseMetadata {
/**
* Parse the seed phrase metadata from the metadata store and return the array of raw seed phrases.
*
* This method also sorts the seed phrases by timestamp in descending order, i.e. the newest seed phrase will be the first element in the array.
* This method also sorts the seed phrases by timestamp in ascending order, i.e. the oldest seed phrase will be the first element in the array.
*
* @param seedPhraseMetadataArr - The array of SeedPhrase Metadata from the metadata store.
* @returns The array of raw seed phrases.
Expand Down Expand Up @@ -141,7 +141,7 @@ export class SeedPhraseMetadata implements ISeedPhraseMetadata {
*/
static sort(
seedPhrases: SeedPhraseMetadata[],
order: 'asc' | 'desc' = 'desc',
order: 'asc' | 'desc' = 'asc',
): SeedPhraseMetadata[] {
return seedPhrases.sort((a, b) => {
if (order === 'asc') {
Expand Down
Loading
Loading