Support Multi-SRP in SeedlessOnboardingController #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler' into feat/seedless-multi-srp
himanshuchawla009
approved these changes
Apr 29, 2025
| * @param password - The password to verify. | ||
| * @throws {Error} If the password is invalid or the vault is not initialized. | ||
| */ | ||
| async verifyPassword(password: string): Promise<void> { |
There was a problem hiding this comment.
Suggested change
| async verifyPassword(password: string): Promise<void> { | |
| async verifyVaultPassword(password: string): Promise<void> { |
| * | ||
| * @param password - The password to submit. | ||
| */ | ||
| async submitPassword(password: string): Promise<void> { |
There was a problem hiding this comment.
can't we simply call it unlockVault?
| const { keyringId, seedPhrase } = item; | ||
| const backupHash = keccak256AndHexify(seedPhrase); | ||
|
|
||
| const existingBackupMetadata = currentBackupsMetadata.find( |
There was a problem hiding this comment.
use some instead of find since you only need the boolean
There was a problem hiding this comment.
what if there are duplicates in the new data? pls account for that too.
simple way is to concat first and then remove duplicates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Changelog
Checklist