Repository navigation
feat(team-vault): accept connection knock sequences as a team secret - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of VoltiusApp/voltius#550 (port knocking before SSH connect).
Team vaults now accept a host's knock port sequence as a team secret, in the same way as the per-host proxy password (#57).
055_connection_knock_sequence_secret_type.sqlwidensteam_vault_secrets_secret_type_checkwithconnection_knock_sequence. It has the same shape as 043, and every existing type is kept.secret_owner_typemaps it toconnection, so writing it needsPERM_EDIT_CONNECTIONS.canonical_secret_idgivesknock_sequence:<object_id>.list_secretsalready returns every type to members holdingPERM_CONNECTorPERM_VIEW_SECRETS(#190), so connect-only members receive the sequence they need to knock.Deploy order: deploy this before the client release that ships port knocking. Until it is deployed, saving a knock sequence on a team-vault host fails.
Tests: the canonical-id table, the
edit_permission_for_secret_typemapping, and a DB-backedupsert_secret_accepts_connection_knock_sequence.cargo test team_objectspasses 80/80 against the test database.