Repository navigation
feat: port knocking before SSH connect (#550) - #569
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #550.
Hosts can now be protected by port knocking. Voltius sends a configured TCP/UDP knock sequence before it dials SSH, so a router that keeps SSH closed until it sees a knock (MikroTik, knockd) works like any other saved host. Hosts without knocking behave as before.
Requires VoltiusApp/server#100 to be deployed first. Until it is, saving a knock sequence on a team-vault host fails.
What's new
Port Knocking panel (host form → Advanced, under Hosts Chaining)
When it knocks
Reachability
unknown; the plugin API is unchanged.Secrets
knock_sequence:<id>, the same way as the proxy password. On/off, timings and the window are ordinary host settings.Session commands
Also in this PR
devand are identical.Known trade-offs and follow-ups
Testing
cargo fmt --check,clippy -D warnings, andcargo test(824 passed). New tests cover:port_knockstorage and clocks.tsc --noEmitclean, and vitest passes for all ofsrcandtests/. Thehooks/utils/plugins/i18ngroup once exited without a summary while running after another group under load; on its own it passes 218/218 files.port_knock.