Skip to content

fix for 3307 (windows launcher rejects filenames with utf8 chars) #3923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix for 3307 (windows launcher rejects filenames with utf8 chars) #3923

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6dc2146
fix for 3307; windows launcher can run scripts with utf8 chars
philwalk Oct 25, 2025
9f7cfb5
fix for macos
philwalk Oct 25, 2025
28a1116
corrected SAVED_CODEPAGE
philwalk Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/scripts/generate-native-image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,31 @@ COMMAND="cli[].base-image.writeDefaultNativeImageScript"
# see https://www.graalvm.org/release-notes/22_2/#native-image
export USE_NATIVE_IMAGE_JAVA_PLATFORM_MODULE_SYSTEM=false

export MSYS_NO_PATHCONV=1 # prevent /d from being converted to d:\
export MSYS2_ARG_CONV_EXCL="*"

function setCodePage {
local CODEPAGE=$1 ; shift
reg add "HKLM\SYSTEM\CurrentControlSet\Control\Nls\CodePage" /v ACP /t REG_SZ /d $CODEPAGE /f
}
function getCodePage {
reg query "HKLM\SYSTEM\CurrentControlSet\Control\Nls\CodePage" /v ACP | grep '[0-9]' | sed -E -e 's#[^0-9]*$##' -e 's#^.*[^0-9]##'
}
SAVED_CODEPAGE=`getCodePage`
echo "SAVED_CODEPAGE[$SAVED_CODEPAGE]" 1>&2

function atexit {
if [ -n "$SAVED_CODEPAGE" ]; then
set -x
reg add "HKLM\SYSTEM\CurrentControlSet\Control\Nls\CodePage" /v ACP /t REG_SZ /d $SAVED_CODEPAGE /f
fi
}

# Using 'mill -i' so that the Mill process doesn't outlive this invocation
if [[ "$OSTYPE" == "msys" || "$OSTYPE" == "cygwin" ]]; then
trap atexit EXIT INT TERM
setCodePage 65001 # set code page to UTF-8 before GraalVM compile

./mill.bat -i ci.copyJvm --dest jvm
export JAVA_HOME="$(pwd -W | sed 's,/,\\,g')\\jvm"
export GRAALVM_HOME="$JAVA_HOME"
Expand Down
Loading