fix for 3307 (windows launcher rejects filenames with utf8 chars) #3923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
generate-native-image.shto generatescala-cli.exewith code page set to 65001 if running in Windows:Using a test script named
/opt/ue/jsrc/løp.sc:and with the PATH set to use the generated
scala-cli.exe:PATH="out/cli/3.3.7/base-image/nativeImage.dest:$PATH"Manual verification that the bug and the fix depend on the code page set during GraalVM compile.
verify the bug
create a buggy
scala-cli.exeby runninggenerated-native-image.shtemporarily modified to set code page 437Verify that the bug manifests itself when attempting to execute the script:
Verify the fix
create fixed
scala-cli.exeby runninggenerated-native-image.shas proposed in this PR (set code page 65001)Verify that the bug is fixed:
# /opt/ue/jsrc/løp.sc Hello /opt/ue/jsrc/løp.sc Hello C:/opt/ue/jsrc/løp.sc Hello løp.sc