Review #1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,86 +1,114 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=>" /> | ||
| <meta http-equiv="X-UA-Compatible" content="ie=edge" /> | ||
| <title>GitHub Login</title> | ||
| <style> | ||
| body { | ||
| font-family: Arial, Helvetica, sans-serif; | ||
| } | ||
| .paragraph { | ||
| width: 260px; | ||
| font-size: 11.5px; | ||
| color: rgb(122, 123, 126); | ||
| margin-left: 5px; | ||
| line-height: 18px; | ||
| } | ||
| .inputs { | ||
| width: 260px; | ||
| height: 43px; | ||
| border-radius: 5px; | ||
| border: groove; | ||
| margin-top: 8px; | ||
| } | ||
| #lastInput { | ||
| margin-bottom: -5px; | ||
|
There was a problem hiding this comment. There are only rare occasions where you want to do negative margins, and this isn't one of them. Target the p element below and make its top margin smaller |
||
| } | ||
| .labelClass { | ||
| font-size: 13px; | ||
| margin-top: -100px; | ||
| color: rgb(92, 93, 95); | ||
| } | ||
| .button { | ||
| background-color: rgb(42, 189, 72); | ||
| width: 260px; | ||
| height: 70px; | ||
| color: white; | ||
| font-size: 16px; | ||
| font-family: Verdana, Geneva, sans-serif; | ||
|
There was a problem hiding this comment. On rare occasions we have two fonts, buttons aren't the case tho 🙂 In 99% of the cases, fonts are only set on the body tag |
||
| border-radius: 5px; | ||
| text-align: middle; | ||
| margin-bottom: -5px; | ||
| } | ||
| #tab1 { | ||
| margin-left: 12px; | ||
| } | ||
| #tab2 { | ||
| margin-left: 10px; | ||
| } | ||
| body > section > p > a { | ||
|
There was a problem hiding this comment. doing just a {
text-decoration: none;
}would suffice |
||
| text-decoration: none; | ||
| } | ||
| body > section { | ||
|
There was a problem hiding this comment. Html tag selectors should always go on the top |
||
| font-size: 12px; | ||
| } | ||
| body { | ||
|
There was a problem hiding this comment. Never target the element twice unless you really have to. move rule up in the first body selector |
||
| margin-left: 15px; | ||
| } | ||
| </style> | ||
| </head> | ||
| <body> | ||
| <form> | ||
| <label for="first" class="labelClass">Username<br /></label> | ||
| <input | ||
| type="text" | ||
| name="username" | ||
| placeholder=" Pick a username" | ||
| class="inputs" | ||
| id="first" | ||
| /><br /> | ||
| <label for="second" class="labelClass"><br />Email<br /></label> | ||
| <input | ||
| type="text" | ||
| name="email" | ||
| placeholder=" [email protected]" | ||
| class="inputs" | ||
| id="second" | ||
| /><br /> | ||
| <label for="third" class="labelClass"><br />Password<br /></label> | ||
| <input | ||
| id="lastInput" | ||
| type="text" | ||
| name="password" | ||
| placeholder=" Create a password" | ||
| class="inputs" | ||
| id="third" | ||
| /><br /> | ||
| <p class="paragraph"> | ||
| Make sure it's more than 15 characters, or at least 8 characters, | ||
| including a number, and a lowercase letter. | ||
| </p> | ||
| <button class="button" type="submit">Sign up for GitHub</button> | ||
| </form> | ||
|
|
||
| <section> | ||
| <p class="paragraph"> | ||
| By clicking "Sign up fot GitHub", you agree to our | ||
| <a | ||
| href="https://help.github.com/articles/github-terms-of-service/" | ||
| id="tab1" | ||
| > | ||
| terms of service</a | ||
| > | ||
| and | ||
| <a href="https://help.github.com/articles/github-privacy-statement/" | ||
| >privacy statement.</a | ||
| > | ||
| We'll | ||
| <text id="tab2"> occasionally send you account related emails.</text> | ||
|
There was a problem hiding this comment. This tag doesn't exist, and you don't need it here :) |
||
| </p> | ||
| </section> | ||
| </body> | ||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This border is pretty off 😄