Review #1
Review #1
Conversation
| width: 260px; | ||
| height: 43px; | ||
| border-radius: 5px; | ||
| border: groove; |
There was a problem hiding this comment.
This border is pretty off 😄
| margin-top: 8px; | ||
| } | ||
| #lastInput { | ||
| margin-bottom: -5px; |
There was a problem hiding this comment.
There are only rare occasions where you want to do negative margins, and this isn't one of them.
Target the p element below and make its top margin smaller
| height: 70px; | ||
| color: white; | ||
| font-size: 16px; | ||
| font-family: Verdana, Geneva, sans-serif; |
There was a problem hiding this comment.
On rare occasions we have two fonts, buttons aren't the case tho 🙂
In 99% of the cases, fonts are only set on the body tag
| #tab2 { | ||
| margin-left: 10px; | ||
| } | ||
| body > section > p > a { |
There was a problem hiding this comment.
doing just
a {
text-decoration: none;
}would suffice
| body > section { | ||
| font-size: 12px; | ||
| } | ||
| body { |
There was a problem hiding this comment.
Never target the element twice unless you really have to. move rule up in the first body selector
| body > section > p > a { | ||
| text-decoration: none; | ||
| } | ||
| body > section { |
There was a problem hiding this comment.
Html tag selectors should always go on the top
| >privacy statement.</a | ||
| > | ||
| We'll | ||
| <text id="tab2"> occasionally send you account related emails.</text> |
There was a problem hiding this comment.
This tag doesn't exist, and you don't need it here :)
No description provided.