Skip to content

Protect calls to fork with a gc_lock on MacOS #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Protect calls to fork with a gc_lock on MacOS #2125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion mono/metadata/w32process-unix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1488,6 +1488,15 @@ close_my_fds (void)
}
#endif

#if defined (HAVE_FORK)
static void* fork_helper(void* data)
{
pid_t* pid = (pid_t*)data;
*pid = fork();
return NULL;
}
#endif

static gboolean
process_create (const gunichar2 *appname, const gunichar2 *cmdline,
const gunichar2 *cwd, StartupHandles *startup_handles, MonoW32ProcessInfo *process_info)
Expand Down Expand Up @@ -1849,7 +1858,12 @@ process_create (const gunichar2 *appname, const gunichar2 *cmdline,
mono_trace (G_LOG_LEVEL_DEBUG, MONO_TRACE_IO_LAYER_PROCESS, "%s: new process startup not synchronized. We may not notice if the newly created process exits immediately.", __func__);
}

switch (pid = fork ()) {
#if defined(HOST_DARWIN) && defined(TARGET_AMD64)
mono_gc_invoke_with_gc_lock(fork_helper, &pid);
#else
pid = fork();
#endif
switch (pid) {
case -1: /* Error */ {
mono_w32error_set_last (ERROR_OUTOFMEMORY);
ret = FALSE;
Expand Down