Protect calls to fork with a gc_lock on MacOS #2125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On MacOS running under Rosetta there is a hang if you are calling fork from one thread and thread_suspend from another. (I believe the suspend call is attempting to suspend the forking thread) We call thread_suspend on all managed threads when doing a GC. We can avoid the collision of calls if we use mono_gc_invoke_with_gc_lock to protect the fork call. I do not believe this is needed on other platforms or chips. I suspect this is a Rosetta problem that we need to work around.
UnityAlex
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS running under Rosetta there is a hang if you are calling fork from one thread and thread_suspend from another. (I believe the suspend call is attempting to suspend the forking thread)
We call thread_suspend on all managed threads when doing a GC. We can avoid the collision of calls if we use mono_gc_invoke_with_gc_lock to protect the fork call.
I do not believe this is needed on other platforms or chips. I suspect this is a Rosetta problem that we need to work around.
This is a backport of #2124
Release notes
Fixed UUM-101541 @bill-holmes:
Mono: Fix Process.Start hangs on intel mac editors running on apple silicon