Repository navigation
ci(release): allow the address the signing vault reports for the runner - #374
Merged
Merged
Conversation
The vault can see the runner under another address than the IP services report, so the rule for the detected IP never matched. The reachability check now prints the vault's error code and client address, allows that address when it differs, and the close step removes every rule the job added. Signed-off-by: Cosmin Staicu <cosmin.staicu@uipath.com>
cosmin-staicu
requested review from
alinahornet,
florin-munteanu-uipath,
litheon,
lucianaparaschivei and
razvalex
as code owners
November 5, 2026 18:36
|
🔎 Maintainer heads-up: automated triage flagged this PR as potentially material, so it may need a signed CLA in addition to the DCO sign-off. Strong signals
This is advisory only — the bot does not decide. Please judge against the CLA criteria (material, product-critical, patent-sensitive, corporate contributor, broad commercial use). Note that thresholds can be gamed by splitting PRs, so use your judgement.
|
…derr Signed-off-by: Cosmin Staicu <cosmin.staicu@uipath.com>
razvalex
approved these changes
Nov 5, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
The publish job added a firewall rule for the runner's IP (from an IP lookup service), but the signing vault kept refusing it for all 20 tries. Runners inside Azure can reach the vault under another address than the one the lookup returns, and the check hid the vault's error, so the log could not show it.
Evidence
Adding IP rule <runner ip>/32thennot reachable yetfor 12+ tries with no reason shown.bash -eo pipefailwith stubbedaz/curl: a vault that reports another client address gets a second rule and is reachable on the next try; a vault that sees the detected IP is reachable after one wait; the close step removes both rules. The log shows only the error code and the client address, never the token or the caller identity.Merge Danger
Door: two-way
Blast Radius: release publish job only. It may add one more
/32rule to the signing vault for the duration of the job; the close step runs withalways()and removes every rule the job added.