Repository navigation
test: count own-message allocations on the receiving thread - #375
Merged
Merged
Conversation
The test summed allocations across the process, so a busy runner's background threads pushed the own-message cost past its 16-byte bound (41 bytes on a Linux CI run). Receive runs on the test thread, so count that thread only, as the other allocation tests do. Signed-off-by: Cosmin Staicu <cosmin.staicu@uipath.com>
cosmin-staicu
requested review from
alinahornet,
florin-munteanu-uipath,
litheon,
lucianaparaschivei and
razvalex
as code owners
November 5, 2026 18:59
|
florin-munteanu-uipath
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
RedisPubSubOwnMessageAllocationTestssummed allocations across the whole process, so other threads on a busy runner counted against the own-message bound.Receiveruns synchronously on the test thread, so the test now counts that thread only, as the repo's other allocation tests do.Evidence
Expected value to be less than 16L because an own message is read for its source and dropped (measured 41 bytes), but found 41L.Merge Danger
Door: two-way
Blast Radius: one test file.