Skip to content

Make lines drawn the same frame they are called #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

CleanCut
Copy link
Contributor

While working on some updates to Rusty Engine I started using this plugin to draw debug lines representing the colliders on my sprites. Since the sprites were in motion, I noticed that the debug lines were consistently drawn 1 frame later, which was annoying.

After poking around a bit, I found that if you move the systems from CoreStage::Last to CoreStage::PostUpdate, then they were drawn in the same frame! This is much nicer.

I have tested this only with the release version of Bevy 0.5.

@Toqozz
Copy link
Owner

Toqozz commented Dec 29, 2021

Thanks for this, I should have considered that. Just sorting out #10 first which touches a lot of the same code and then I'll merge/change this :).

@CleanCut
Copy link
Contributor Author

Cool, thanks!

@Toqozz
Copy link
Owner

Toqozz commented Jan 6, 2022

Just gonna push this through now as #10 is gonna take a while.

@Toqozz Toqozz merged commit 1662c4c into Toqozz:master Jan 6, 2022
@CleanCut
Copy link
Contributor Author

CleanCut commented Jan 6, 2022

Cool, thanks! When do you plan on issuing the next release?

@Toqozz
Copy link
Owner

Toqozz commented Jan 6, 2022

I'll try to push a release tonight with this fix (sorry if I forget!)

@CleanCut
Copy link
Contributor Author

CleanCut commented Jan 6, 2022

That sounds great, thanks! (no worries if you forget, life is busy 😄)

@Toqozz
Copy link
Owner

Toqozz commented Jan 7, 2022

Just published 0.3.4 :)

@CleanCut
Copy link
Contributor Author

CleanCut commented Jan 8, 2022

Ah, that is so much nicer. Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants