Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): background color when disabled and checked #264

Merged
merged 4 commits into from
Jan 9, 2025
Merged

fix(radio): background color when disabled and checked #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a44fcd
fix: first fix proposal
joacotornello Jan 8, 2025
a87eb85
fix: added yml path
joacotornello Jan 8, 2025
9af8757
fix: yml commit
joacotornello Jan 8, 2025
5041130
fix: added changelog
joacotornello Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .yarn/versions/da9e321b.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
releases:
"@nimbus-ds/styles": patch

declined:
- nimbus-design-system
6 changes: 6 additions & 0 deletions packages/core/styles/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

Nimbus Styles deprive all styles needed to build nimbus components.

## 2025-01-09 `9.11.7`

#### 🐛 Bug fixes

- We detected that when the radio component, when displayed as a button, didn't match the [Figma](https://www.figma.com/design/TDwgeblsVNeHKKRvoDRk7n/%E2%98%81%EF%B8%8F-Nimbus-v2.0?node-id=2609-46017&p=f&t=4qBwkk1Tk4JoHDsS-0) specified colors for both **disabled** and **checked** enabled attributes at the same time. ([#264](https://github.com/TiendaNube/nimbus-design-system/pull/264) by [@joacotornello](https://github.com/joacotornello) )

## 2024-12-18 `9.11.6`

#### 🐛 Bug fixes
Expand Down
4 changes: 2 additions & 2 deletions packages/core/styles/src/packages/atomic/radio/nimbus-radio.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ globalStyle(`${container__input}:checked ~ ${container__content.button}`, {
});

globalStyle(`${container__input}:checked ~ ${container__content.disabled}`, {
backgroundColor: varsThemeBase.colors.neutral.surfaceDisabled,
backgroundColor: varsThemeBase.colors.neutral.textDisabled,
borderColor: varsThemeBase.colors.neutral.surfaceHighlight,
color: varsThemeBase.colors.neutral.textDisabled,
color: varsThemeBase.colors.neutral.background,
});

export const styles = {
Expand Down
Loading