Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): background color when disabled and checked #264

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

joacotornello
Copy link
Contributor

@joacotornello joacotornello commented Jan 8, 2025

Type

  • Bugfix 🐛

Changes proposed ✔️

@nimbus-ds/[email protected]|patch

🐛 Bug fixes

  • We detected that when the radio component, when displayed as a button, didn't match the Figma specified colors for both disabled and checked enabled attributes at the same time. (#244 by @ManuAhumada)

  • Before: (check bug)

  • After:

Grabacion.de.pantalla.2025-01-08.a.la.s.4.22.57.p.m.mov

Jira

NIMBUS-6

@joacotornello joacotornello requested a review from a team as a code owner January 8, 2025 19:18
Copy link

github-actions bot commented Jan 8, 2025

Getting started

Please make sure you read our documentation on how to write code for components, stories and styles.

  • Provide a list of changes
  • Include images to help better visualize your work
  • If your PR closes an issue, please link it
  • Add reviewers
  • Add a label to help better understand what your changes are related to

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.24%. Comparing base (2c6415f) to head (5041130).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files         298      298           
  Lines        1979     1979           
  Branches      292      292           
=======================================
  Hits         1964     1964           
  Misses         13       13           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joacotornello joacotornello changed the base branch from master to release January 9, 2025 13:04
@joacotornello joacotornello changed the base branch from release to master January 9, 2025 13:06
Copy link

sonarqubecloud bot commented Jan 9, 2025

@joacotornello joacotornello merged commit ec516d8 into master Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants