Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/skills/code-review/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,24 @@ suggest the fix — never just "rejected".
- [ ] Descriptive variable and function names (no single letters where a word helps).
- [ ] Code is formatted and lint-clean (`ruff`, `pre-commit`).

#### When a PR fails `ruff check`

Don't just report the failure — try the mechanical fixes and recommend the one
that works, in this order:

1. Run `ruff check --fix file_path.py`. If that makes the file pass, recommend
that solution — these are the fixes `ruff` considers **safe**.
2. If it still fails, run `ruff check --fix --unsafe-fixes file_path.py`. If that
makes the file pass **and** the resulting diff is genuinely safe (it preserves
behavior — review it, don't trust it blindly), recommend that solution and note
that it required `--unsafe-fixes`.
3. If neither passes, or the unsafe fix would change behavior, describe the
remaining rule violations and the manual change the author needs to make.

Always quote the exact rule code(s) `ruff` reports (e.g., `ruff rule UP047`,
`ruff rule RUF100`) so the author can run those commands to read the rules being
flagged. Also, paste the concrete command you ran.

### 3. Other Requirements for Submissions

- [ ] At least one **Wikipedia (or equivalent) URL** documenting the algorithm.
Expand Down
Loading