Skip to content

docs(skill): recommend ruff --fix workflow for PRs failing ruff check - #15218

Merged
cclauss merged 2 commits into
TheAlgorithms:masterfrom
priya-sundaram-dev:skill/ruff-fix-recommendations
Sep 7, 2026
Merged

docs(skill): recommend ruff --fix workflow for PRs failing ruff check#15218
cclauss merged 2 commits into
TheAlgorithms:masterfrom
priya-sundaram-dev:skill/ruff-fix-recommendations

Conversation

@priya-sundaram-dev

@priya-sundaram-dev priya-sundaram-dev commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Per @cclauss's request in #15081, this adds a When a PR fails ruff check subsection to .github/skills/code-review/SKILL.md.

It gives reviewers a fixed, repeatable procedure:

  1. Try ruff check --fix file_path.py (safe fixes) — if the file passes, recommend that.
  2. Otherwise try ruff check --fix --unsafe-fixes file_path.py — if it passes and the diff genuinely preserves behavior, recommend that and note it needed --unsafe-fixes.
  3. If neither works (or the unsafe fix changes behavior), describe the remaining violations and the manual fix.

It also reminds the reviewer to quote the exact rule codes (e.g. UP047, RUF100) and paste the command they ran, so the author knows exactly what to do.

Refs #15081.

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one file (.github/skills/code-review/SKILL.md); it is a documentation-only change, not a new algorithm.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Sep 7, 2026
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@priya-sundaram-dev, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot closed this Sep 7, 2026
@algorithms-keeper
algorithms-keeper Bot removed the request for review from cclauss September 7, 2026 05:39
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 7, 2026
@cclauss cclauss reopened this Sep 7, 2026
@algorithms-keeper algorithms-keeper Bot added the documentation This PR modified documentation files label Sep 7, 2026
Comment thread .github/skills/code-review/SKILL.md Outdated
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Sep 7, 2026
@cclauss
cclauss merged commit ca133c7 into TheAlgorithms:master Sep 7, 2026
5 checks passed
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This PR modified documentation files invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants