[php] Patch to fix Nginx Unit dockerfile #7757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As only fail sometimes
|
Ready to be merged !! |
tippexs
reviewed
Dec 2, 2022
There was a problem hiding this comment.
Thanks for letting me know. This is an interim fix. We will ship a new version of our docker-entrypoint.sh script (https://github.com/nginx/unit/blob/master/pkg/docker/docker-entrypoint.sh) with the next version of NGINX Unit 1.29. Therfore the containers will be updated accordingly.
There is nothing wrong patching it now BUT we are about to release a new Version within the next 2 weeks probably. So maybe a manual fix is not worth it.
joanhey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Timo @tippexs from Nginx 👍
#7703