The last versions of Nginx Unit fails in the TechEmpower benchmark

[joanhey]

Hi,
I added Nginx and Nginx Unit to the TechEmpower benchmark.
But in the last versions it's failing with PHP:
https://tfb-status.techempower.com/unzip/results.2022-11-25-12-16-16-174.zip/results/20221119184855/php-unit/run/php-unit.log

Old config without problems, and faster than Nginx:
https://github.com/TechEmpower/FrameworkBenchmarks/blob/R20/frameworks/PHP/php/php-unit.dockerfile
https://github.com/TechEmpower/FrameworkBenchmarks/blob/R20/frameworks/PHP/php/deploy/nginx-unit.json

Actual config with problems:
https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/PHP/php/php-unit.dockerfile
https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/PHP/php/deploy/nginx-unit.json

The last versions fail a lot.

Please, could anybody review and help with this problem.
Thank you.

PD: Welcome help with the Nginx config too, only with the plaintext test.
https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/C/nginx/nginx.conf

Be careful, as the bench changed a lot after the spectre/meldown patches.
TechEmpower/FrameworkBenchmarks#7321

If you need I'll send you the benchs results. And ask me for any doubt.

[ac000]

Looking at the log it seems

php-unit: /usr/local/bin/docker-entrypoint.sh: Applying configuration /docker-entrypoint.d/nginx-unit.json
php-unit: 2022/11/23 16:50:03 [info] 21#21 "benchmark" prototype started

Unit was started with some initial config.

php-unit: 2022/11/23 16:50:03 [info] 105#105 "benchmark" application started
php-unit: /usr/local/bin/docker-entrypoint.sh: OK: HTTP response status code is '200'
php-unit: {
php-unit: 	"success": "Reconfiguration done."
php-unit: }
php-unit: /usr/local/bin/docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/...
php-unit: /usr/local/bin/docker-entrypoint.sh: Stopping Unit daemon after initial configuration...
php-unit: /usr/local/bin/docker-entrypoint.sh: Waiting for control socket to be removed...
php-unit: 2022/11/23 16:50:03 [alert] 21#21 sendmsg(20, -1, -1, 1) failed (104: Connection reset by peer)

After it was started it was reconfigured, then shutdown. All that happened within the space of a second.

From your point of view, what was the actual sequence of events?

[joanhey]

The strange thing is that in local work.
Show all that verbose output, but work.

Finish here and start to verify the tests:

When finish the tests and close the docker:

Before show the summary:

But not in github actions or the bench server.

Github actions log failing:
https://github.com/TechEmpower/FrameworkBenchmarks/actions/runs/3567839471/jobs/5996024544#step:9:4375

[joanhey]

It's failing from the last 2 versions of Nginx Unit.
And sometimes work !!

Here are the logs from an old run, using unit_1.21.0 and php7.4 working without problems.
https://tfb-status.techempower.com/unzip/results.2021-01-13-13-38-00-107.zip/results/20201229183947/php-unit

And an actual, using FROM nginx/unit:1.28.0-php8.1
https://tfb-status.techempower.com/unzip/results.2022-11-25-12-16-16-174.zip/results/20221119184855/php-unit

A recent run that half worked, using FROM nginx/unit:1.27.0-php8.1
https://tfb-status.techempower.com/unzip/results.2022-11-13-10-29-24-097.zip/php-unit
A picture from the fortunes results, from this run.

But json, db and query tests failed the verification and the log show a lot of errors:
https://tfb-status.techempower.com/unzip/results.2022-11-13-10-29-24-097.zip/results/20221107183025/php-unit/run/php-unit.log
I updated for that to v1.28, but now never work.

[joanhey]

When I send the PR for Nginx Unit 1.28 was passing the github actions tests.
But never in the bench server, and later again failed in github actions.

TechEmpower/FrameworkBenchmarks#7691

Github actions log working:
https://github.com/TechEmpower/FrameworkBenchmarks/actions/runs/3447671893/jobs/5753927577#step:9:2154

[tippexs]

As discussed on the community slack https://nginxcommunity.slack.com/archives/C02SS9UB85C/p1670008983875989?thread_ts=1669810946.221959&cid=C02SS9UB85C

This issue is related to #728 and friends. A manual patch of the docker-entrypoint.sh file seems to fix the issue.

Linking the external issue as well.

TechEmpower/FrameworkBenchmarks#7757 (review)

As said, we will ship a fix for the entrypoint script with the next Unit release 1.29.

[joanhey]

If work in the next run. I'll close the issue.

[tippexs]

I will close it once the fix was merged if that's okay for you