-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #907: Translate Time to Leave to Portuguese (pt-PT) #908
Conversation
Some pt-PT translations were incorrect on locales/pt-PT/translation.json
Test path: __tests__/__main__/user-preferences.js
Added some forgotten translations in the file docs/README-pt-PT.md
Codecov Report
@@ Coverage Diff @@
## main #908 +/- ##
==========================================
- Coverage 73.67% 71.45% -2.23%
==========================================
Files 17 17
Lines 1755 1755
Branches 278 278
==========================================
- Hits 1293 1254 -39
- Misses 462 501 +39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I just have two small comments on the readme :)
Due to distractions I had to correct some typos
Now the errors seem to be resolved Thanks in advance |
That's not a problem, as long as there are no merge conflicts (and we don't have one currently) we can merge even if it's out of sync. |
Nice, there is anything else I can do to help? |
\changelog-update |
That's it @drcor , thanks for the contribution! Do you want us to keep your handle as our contact if there's ever a new string to be translated into Portuguese (Portugal)? |
Sure @tupaschoal, anytime |
Related issue
Closes #907
Context / Background
I added the translation to Portuguese from Portugal (pt-PT)
What change is being introduced by this PR?
I have followed all the guidelines in the issue #475 to do the translation correctly, hope I didn't forget anything.