Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #907: Translate Time to Leave to Portuguese (pt-PT) #908

Merged
merged 8 commits into from
Nov 20, 2022
Merged

Close #907: Translate Time to Leave to Portuguese (pt-PT) #908

merged 8 commits into from
Nov 20, 2022

Conversation

drcor
Copy link
Contributor

@drcor drcor commented Nov 17, 2022

Related issue

Closes #907

Context / Background

I added the translation to Portuguese from Portugal (pt-PT)

What change is being introduced by this PR?

I have followed all the guidelines in the issue #475 to do the translation correctly, hope I didn't forget anything.


  • I confirm I'm a native or fluent speaker of the language I'm translating to.

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #908 (b941a4e) into main (3de13ab) will decrease coverage by 2.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
- Coverage   73.67%   71.45%   -2.23%     
==========================================
  Files          17       17              
  Lines        1755     1755              
  Branches      278      278              
==========================================
- Hits         1293     1254      -39     
- Misses        462      501      +39     
Impacted Files Coverage Δ
js/classes/FlexibleDayCalendar.js 58.65% <0.00%> (-6.37%) ⬇️
js/classes/FlexibleMonthCalendar.js 56.25% <0.00%> (-4.17%) ⬇️
js/classes/BaseCalendar.js 55.34% <0.00%> (-2.68%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I just have two small comments on the readme :)

docs/README-pt-PT.md Outdated Show resolved Hide resolved
Due to distractions I had to correct some typos
@drcor
Copy link
Contributor Author

drcor commented Nov 19, 2022

Now the errors seem to be resolved
I noticed that my fork is 3 commits behind the thamara:main, what should I do?

Thanks in advance

@tupaschoal
Copy link
Collaborator

That's not a problem, as long as there are no merge conflicts (and we don't have one currently) we can merge even if it's out of sync.

@drcor
Copy link
Contributor Author

drcor commented Nov 20, 2022

Nice, there is anything else I can do to help?

@tupaschoal
Copy link
Collaborator

\changelog-update
Message: Translation: Time to Leave is now available in Portuguese (pt-PT)!

@tupaschoal tupaschoal changed the title Translate Time to Leave to Portuguese (pt-PT) Close #907: Translate Time to Leave to Portuguese (pt-PT) Nov 20, 2022
@tupaschoal tupaschoal merged commit 74e128e into TTLApp:main Nov 20, 2022
@tupaschoal
Copy link
Collaborator

That's it @drcor , thanks for the contribution!

Do you want us to keep your handle as our contact if there's ever a new string to be translated into Portuguese (Portugal)?

@drcor
Copy link
Contributor Author

drcor commented Nov 20, 2022

Sure @tupaschoal, anytime

@drcor drcor deleted the translation/portuguese branch November 20, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate Time to Leave to pt/pt-PT
2 participants