Removing support of old database (fixed 4 entries) #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1095 +/- ##
==========================================
+ Coverage 64.87% 65.80% +0.92%
==========================================
Files 22 22
Lines 3374 3205 -169
Branches 488 456 -32
==========================================
- Hits 2189 2109 -80
+ Misses 1185 1096 -89 ☔ View full report in Codecov by Sentry. |
| @@ -10,14 +10,14 @@ import { | |||
| } from '../../js/time-balance.js'; | |||
| import { resetPreferences } from '../../js/user-preferences.js'; | |||
|
|
|||
| const flexibleStore = new Store({name: 'flexible-store'}); | |||
| const entryStore = new Store({name: 'flexible-store'}); | |||
There was a problem hiding this comment.
maybe just store or calendarStore ? entry doesn't say much
There was a problem hiding this comment.
I can, made it entryStore because you had previously suggested either entryStore or store on Thamara's PR hehehe
araujoarthur0
approved these changes
Dec 26, 2024
|
\changelog-update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #935.
Supersedes #1053 (because I'm lazy to clone again and fix the commits and merge conflicts there)
Context / Background
The old database format (fixed in 4 entries) is in deprecation since may of 2021, as we move with other features, it's time to remove any mention/handling of such database.
What change is being introduced by this PR?
Removed related code and unnecessary strings.
How will this be tested?
Hopefully with the CI. :)