Deprecate old db #1053
Closed
Deprecate old db #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1053 +/- ##
==========================================
+ Coverage 79.36% 81.29% +1.93%
==========================================
Files 19 20 +1
Lines 1231 1203 -28
Branches 183 176 -7
==========================================
+ Hits 977 978 +1
+ Misses 254 225 -29 ☔ View full report in Codecov by Sentry. |
tupaschoal
approved these changes
Jan 8, 2024
| @@ -144,26 +130,12 @@ function importDatabaseFromFile(filename) | |||
| } | |||
| else | |||
| { | |||
| assert(entry.type === 'flexible'); | |||
There was a problem hiding this comment.
Can we write something on the test that hit this assert?
|
I have solved merge conflicts here and the issues raised on #1095 , so I'm closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #935.
Context / Background
The old database format (fixed in 4 entries) is in deprecation since may of 2021, as we move with other features, it's time to remove any mention/handling of such database.
What change is being introduced by this PR?
Removed related code and unnecessary strings.
How will this be tested?
Hopefully with the CI. :)