-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temporary patch alternative to #2643 #2664
Closed
+39
−30
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f6ab7a7
Reformulated remark for xmlns in root elements (TEI and teiCorpus). A…
GusRiva 4658cf1
Corrected typo
GusRiva 796f4ed
Add div to att.placement
sydb 59ad3a6
Apply suggestions per @HelenaSabel code review
sydb 0ebc38c
Grab latest from dev
sydb 10ed15e
Merge pull request #2632 from TEIC/issue-2621
trishaoconnor 2b307d6
Add postscript element to
sydb ee8c777
Add div to att.placement
sydb 6277543
Add postscript element to
sydb 2c11f90
Merge branch 'sydb_2551_place_on_div' of github.com:TEIC/TEI into syd…
sydb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sydb @HelenaSabel I found this commit just now, as part of the work you were doing in this branch re att.placement the other day. I think the commit was intended for a different branch or a different ticket, b/c this PR was't for modifying the Spanish remarks on
<TEI>
and<teiCorpus>
. In closing this branch, I didn't want us to lose track of this commit!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sydb @HelenaSabel Aha. I think these revised remarks were already incorporated in a different PR: #2632