temporary patch alternative to #2643 #2664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded Spanish translation of the remark
Co-authored-by: Helena Bermúdez Sabel <[email protected]>
Reformulated remark for xmlns in root elements (TEI and teiCorpus)
att.placement per #2542. Also fixed a bunch of whitespace while I was in there.
att.placement per #2542. Also fixed a bunch of whitespace while I was in there.
…b_2551_place_on_div
|
Implemented in a different way through #2665 |
ebeshero
reviewed
Jan 23, 2025
| @@ -202,7 +202,7 @@ | |||
| <tag type="start">TEI version="4.8.1" xml:lang="it" xmlns="http://www.tei-c.org/ns/1.0"</tag>.</p> | |||
| </remarks> | |||
| <remarks versionDate="2024-12-10" xml:lang="es"> | |||
| <p>Como todos los elementos en el esquema TEI (excepto <gi>egXML</gi>), este elemento se encuentra en el espacio de nombre (<foreign>namespace</foreign>) de TEI (cf. <ptr target="#SGname"/>). Por lo tanto, cuando se lo utiliza como el elemento más externo rn un documento TEI, es necesario especificar el nombre de espacio de TEI en su interior. Esto se logra, normalmente, al incluir <ident type="ns">http://www.tei-c.org/ns/1.0</ident> como valor de la declaración de nombre de espacio (xmlns) sin indicar un prefijo, y por lo tanto sin necesidad de utilizar un prefijo en los elementos TEI del resto del documento. Por ejemplo: <tag type="start">TEI version="4.8.1" xml:lang="it" xmlns="http://www.tei-c.org/ns/1.0"</tag>.</p></remarks> | |||
| <p>Como todos los elementos en el esquema TEI (excepto <gi>egXML</gi>), este elemento se encuentra en el espacio de nombres (<foreign>namespace</foreign>) de TEI (cf. <ptr target="#SGname"/>). Por lo tanto, cuando se utiliza como el elemento más externo de un documento TEI, es necesario especificar el espacio de nombres de TEI en su interior. Esto se hace, normalmente, incluyendo <ident type="ns">http://www.tei-c.org/ns/1.0</ident> como valor de la declaración de espacio de nombres (xmlns) sin indicar un prefijo, y por lo tanto sin necesidad de utilizar un prefijo en los elementos TEI del resto del documento. Por ejemplo: <tag type="start">TEI version="4.8.1" xml:lang="it" xmlns="http://www.tei-c.org/ns/1.0"</tag>.</p></remarks> | |||
There was a problem hiding this comment.
@sydb @HelenaSabel I found this commit just now, as part of the work you were doing in this branch re att.placement the other day. I think the commit was intended for a different branch or a different ticket, b/c this PR was't for modifying the Spanish remarks on <TEI> and <teiCorpus>. In closing this branch, I didn't want us to lose track of this commit!
There was a problem hiding this comment.
@sydb @HelenaSabel Aha. I think these revised remarks were already incorporated in a different PR: #2632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we do not either handle the class jiggering or new class naming that would be needed for #2643, this PR just adds
<div>to att.placement in an effort to solve OP request of #2551.