-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformulated remark for xmlns in root elements (TEI and teiCorpus) #2632
Conversation
…dded Spanish translation of the remark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, save two tiny typos. But I only looked at the English; leaving the Spanish review to @HelenaSabel.
Thanks! Corrected the typo in 4658cf1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for the English portions. My Spanish is not good enough to qualify me to review the Spanish paragraph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a few changes related to the Spanish translation of namespace (which, in my opinion should always be espacio de nombres)
Co-authored-by: Helena Bermúdez Sabel <[email protected]>
This looks OK to merge to me, reviewer comments from @sydb and @HelenaSabel have been applied. |
This is to close issue #2621
Modifies the prose of the remark for TEI and teiCorpus. I slightly reformulated the suggestion from @sydb in the issue and added a Spanish translation as well.