Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformulated remark for xmlns in root elements (TEI and teiCorpus) #2632

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

GusRiva
Copy link
Member

@GusRiva GusRiva commented Dec 10, 2024

This is to close issue #2621
Modifies the prose of the remark for TEI and teiCorpus. I slightly reformulated the suggestion from @sydb in the issue and added a Spanish translation as well.

@GusRiva GusRiva requested review from sydb and HelenaSabel December 10, 2024 14:39
@GusRiva GusRiva added the Status: Pending pending action described in a comment, to return to discussion before further action will be taken label Dec 10, 2024
@GusRiva GusRiva added this to the Guidelines 4.9.0 milestone Dec 12, 2024
@GusRiva GusRiva linked an issue Dec 12, 2024 that may be closed by this pull request
Copy link
Member

@sydb sydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, save two tiny typos. But I only looked at the English; leaving the Spanish review to @HelenaSabel.

P5/Source/Specs/TEI.xml Outdated Show resolved Hide resolved
P5/Source/Specs/teiCorpus.xml Outdated Show resolved Hide resolved
@GusRiva
Copy link
Member Author

GusRiva commented Dec 19, 2024

Looks good to me, save two tiny typos. But I only looked at the English; leaving the Spanish review to @HelenaSabel.

Thanks! Corrected the typo in 4658cf1

Copy link
Member

@sydb sydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the English portions. My Spanish is not good enough to qualify me to review the Spanish paragraph.

Copy link
Member

@HelenaSabel HelenaSabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a few changes related to the Spanish translation of namespace (which, in my opinion should always be espacio de nombres)

P5/Source/Specs/TEI.xml Outdated Show resolved Hide resolved
P5/Source/Specs/teiCorpus.xml Outdated Show resolved Hide resolved
Co-authored-by: Helena Bermúdez Sabel <[email protected]>
@sydb sydb removed the Status: Pending pending action described in a comment, to return to discussion before further action will be taken label Jan 21, 2025
@trishaoconnor
Copy link
Contributor

This looks OK to merge to me, reviewer comments from @sydb and @HelenaSabel have been applied.

@trishaoconnor trishaoconnor merged commit 10ed15e into dev Jan 21, 2025
3 checks passed
@trishaoconnor trishaoconnor deleted the issue-2621 branch January 21, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TEI @xmlns
10 participants