Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/anaerobicgrowth&Nitrogen-limited growth #199

Merged
merged 14 commits into from
Nov 11, 2019
Merged

Conversation

feiranl
Copy link
Collaborator

@feiranl feiranl commented Sep 24, 2019

Main improvements in this PR:

  • To update the function anaerobicModel.m to fix the issue mentioned here fix: zero-growth in anaerobic conditions #198. heme was removed as in earlier function. This time, we update the function by removing heme, NAD, NADP, NADPH and NADH when we simulate anaerobic condition.
  • To update the Nitrogen-limited condition growth by rescale the protein content
  • To update a growth test for model validation, which is also the figure S4c for the yeast8 paper.

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

@BenjaSanchez BenjaSanchez added the bug something is wrong in the model label Nov 4, 2019
Benjamín Sánchez added 3 commits November 5, 2019 10:15
so to not rely on added paths
* avoid initializing cobra for speed-up
* linted all files
* some typo fixes
Benjamín Sánchez added 5 commits November 5, 2019 11:24
to avoid undesired changes
* isolate rescalePseudoReaction
* move sumBioMass & fitGAM
MW data is now loaded at the beginning of the function
* scaleBioMass is now a function for scaling any component in the biomass pseudoreaction
* called by anaerobicModel.m and growth.m
* old scaleBioMass is now renamed "fixBiomassComp", to avoid confusion
if lipid is chosen, 2 pseudoreactions need to be rescaled
Copy link
Contributor

@BenjaSanchez BenjaSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feiranl after the refactoring changes I introduced I don't have any more issues, we can merge :)

  • There's a new function scaleBioMass which can be used for rescaling any biomass component, but without the additional changes from the old script. It also has an option for balancing out the total mass so that it adds to 1 g/gDW. The old scaleBioMass has been renamed to fixBiomassComp to be more explicit about its purpose (does not break BC as the old scaleBioMass was not a function to begin with).

  • sumBioMass does not rely on the data input anymore, as it builds it from within.

  • rescalePseudoReaction has been isolated so that it can be called by its parent but also by the new scaleBioMass.

  • I noticed that predictions changed a bit, and this is I believe due to what we discussed before: For example, in the case of N-limited anaerobic conditions, with the old scaleBioMass it didn't matter the changes you were introducing in the nitrogen section, as they were being over-written by the original changes when calling anaerobicModel (which called scaleBioMass again). See below the old code:

    if strcmp(mode2,'N')
        content = {'carbohydrate','protein','lipid backbone','RNA'};
        fraction = [0.587 0.289 0.048 0.077];
        model = scaleBioMass(content,fraction,model,false,false);
    end
    if mode1 == 2
        model = anaerobicModel(model);
    end

    This is now not an issue anymore, however predictions do look slightly worse:

    image

Let me know if the code looks good on your end (especially if the biomass composition for anaerobic/N-limited/etc conditions is being properly built), or if you have any additional comments.

Copy link
Collaborator

@hongzhonglu hongzhonglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@feiranl
Copy link
Collaborator Author

feiranl commented Nov 9, 2019

It looks good from my side. I run the code on MAC, it generate the figure perfectly.

@BenjaSanchez BenjaSanchez merged commit 3d165e6 into devel Nov 11, 2019
@BenjaSanchez BenjaSanchez deleted the feat-anaerobicgrowth branch February 21, 2020 12:59
@BenjaSanchez BenjaSanchez mentioned this pull request Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is wrong in the model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants