Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yeast 8.3.5 #213

Merged
merged 32 commits into from
Apr 2, 2020
Merged

yeast 8.3.5 #213

merged 32 commits into from
Apr 2, 2020

Conversation

BenjaSanchez
Copy link
Contributor

feiranl and others added 30 commits September 24, 2019 17:24
so to not rely on added paths
* avoid initializing cobra for speed-up
* linted all files
* some typo fixes
to avoid undesired changes
* isolate rescalePseudoReaction
* move sumBioMass & fitGAM
MW data is now loaded at the beginning of the function
* scaleBioMass is now a function for scaling any component in the biomass pseudoreaction
* called by anaerobicModel.m and growth.m
* old scaleBioMass is now renamed "fixBiomassComp", to avoid confusion
if lipid is chosen, 2 pseudoreactions need to be rescaled
feat/anaerobicgrowth&Nitrogen-limited growth
to match devel structure/standards
compliant documentation + misc formatting
to guide users on what can and cannot be used
avoid redundancy in  documentation
feat-add a function to test essential genes
remove description lines for checklist, as it lead to mispells by users (e.g. "[ X]") and it is anyways more intuitive to check the boxes later
as there is now a paper
* clarified that greek letters should be avoided
* added a new release step: reviewing the Zenodo release
As discussed in #129, YAR069W-A and YHR214W-F are not from the s288c strain and therefore are here removed
@BenjaSanchez BenjaSanchez added the new release PR from devel to master that leads to a new release label Apr 1, 2020
@BenjaSanchez BenjaSanchez requested a review from feiranl April 1, 2020 08:53
@BenjaSanchez BenjaSanchez self-assigned this Apr 1, 2020
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@BenjaSanchez BenjaSanchez merged commit 130e2c7 into master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new release PR from devel to master that leads to a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cite yeast 8 fix: zero-growth in anaerobic conditions fix: remove genes not found in S288C annotation
3 participants